Skip to content

Simplify README and split source docs#15

Merged
robertoecf merged 4 commits into
mainfrom
codex/objective-readme-source-docs
May 6, 2026
Merged

Simplify README and split source docs#15
robertoecf merged 4 commits into
mainfrom
codex/objective-readme-source-docs

Conversation

@robertoecf
Copy link
Copy Markdown
Owner

@robertoecf robertoecf commented May 5, 2026

Summary

  • Simplifies README.md into an objective project overview, quickstart, docs map, quality gates, and scope note.
  • Moves detailed source coverage, endpoint examples, and access/auth notes into GitHub Markdown docs: docs/SOURCES_AND_ENDPOINTS.md.
  • Removes the temporary /sources web page/route and links source details from the API docs page to the GitHub doc instead.
  • Removes repo references to wealthuman and cleans decorative ASCII-style doc titles from the README path.

Validation

  • .venv/bin/ruff format --check src/ tests/ scripts/
  • .venv/bin/ruff check src/ tests/ scripts/
  • .venv/bin/python -m mypy src/findata
  • .venv/bin/python -m pytest tests/ -q (227 passed, 16 deselected)
  • git diff --check

Notes

  • PR is draft while this documentation direction is being reviewed.
  • Do not merge without explicit approval after checks and bot review comments are inspected.

Summary by CodeRabbit

  • Documentation

    • Complete README restructure with enhanced Portuguese documentation
    • New Sources and Endpoints documentation guide added
    • Reorganized contribution guidelines with clearer tool and guardrail descriptions
  • New Features

    • Added Sources section to documentation web interface
  • Tests

    • Added tests for documentation pages and sources functionality

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 5, 2026

Warning

Rate limit exceeded

@robertoecf has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 48 minutes and 18 seconds before requesting another review.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: df477b1c-0d32-4fc0-8281-834307e3ced6

📥 Commits

Reviewing files that changed from the base of the PR and between fcb334a and 2cf3310.

📒 Files selected for processing (1)
  • docs/SOURCES_AND_ENDPOINTS.md
📝 Walkthrough

Walkthrough

This PR restructures the project's documentation and clarifies its development standards. It introduces a new Portuguese documentation file for sources and endpoints, rewrites the README and CONTRIBUTING guide, updates the web interface navigation, and adjusts comments across multiple configuration and script files to reflect the current guardrails approach.

Changes

Documentation & Project Standards

Layer / File(s) Summary
Project Overview Rewrites
README.md, CONTRIBUTING.md, CHANGELOG.md
README is completely rewritten in Portuguese with structured sections (installation, quick start, sources, documentation, quality, scope, license). CONTRIBUTING is reorganized with clearer guardrails intro and a new "Os três tools da casa" table. CHANGELOG header for Git guardrails is updated for clarity.
Configuration & Script Comments
pyproject.toml, scripts/git/guardrails.sh
Philosophy block in [tool.ruff.lint] is reformatted from prose to bullet points. Guardrails.sh header comment is updated from wealthuman reference to neutral Python/Ruff description.

Documentation Portal & Web Interface

Layer / File(s) Summary
Core Documentation Content
docs/SOURCES_AND_ENDPOINTS.md
New Portuguese documentation file introducing sources and endpoints, REST/CLI examples, offline registry guidance, and authentication notes for Base dos Dados, ANBIMA, and Yahoo Finance.
Web Interface Structure
src/findata/web/templates/docs.html
Navigation is updated: "Endpoints" nav item becomes "Sources". New hero action button links to sources/endpoints documentation. New "Sources" section is inserted before existing "Endpoints" section. Footer "Health" link is replaced with "Labs".
Tests & Verification
tests/test_api.py
Developer docs page test is enhanced with assertions for the new "Sources and endpoints" section and docs link. New test_sources_page_is_not_exposed verifies /sources endpoint returns 404.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • robertoecf/findata-br#6: Both PRs modify the scripts/git/guardrails.sh header comment to update the branding description.

Poem

🐰 A rabbit's welcome to clearer paths,
Portuguese guides in structured graphs,
New portals bloom where docs now shine,
Sources and endpoints aligned by design!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Simplify README and split source docs' accurately summarizes the main changes: README simplification and extraction of source documentation into a separate file.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/objective-readme-source-docs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@robertoecf robertoecf marked this pull request as draft May 5, 2026 19:43
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the project's documentation by moving detailed source and endpoint information from the README to a new dedicated file and a corresponding web page at /sources. The web interface is updated with a new template and improved navigation across the landing, documentation, and labs pages. Feedback identifies opportunities to improve the HTML rendering of technical terms, ensure the copy-to-clipboard functionality handles multiple examples correctly, and maintain footer consistency across all pages.

Comment thread src/findata/web/templates/sources.html Outdated
Comment thread src/findata/web/templates/sources.html Outdated
Comment thread src/findata/web/templates/docs.html
@robertoecf robertoecf marked this pull request as ready for review May 6, 2026 20:33
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/SOURCES_AND_ENDPOINTS.md`:
- Around line 64-72: The example uses top-level await which will raise a
SyntaxError in normal Python scripts; wrap the await calls to lookup(...) inside
an async function (e.g., async def main()) and run it with asyncio.run(main())
so the snippet is directly copy-paste runnable; update the block to import
asyncio, move the five await lookup(...) calls into main(), and call
asyncio.run(main()) at the end.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 74a87604-56e6-4d2d-b208-ab43dc13dc9a

📥 Commits

Reviewing files that changed from the base of the PR and between 4740b9b and fcb334a.

📒 Files selected for processing (8)
  • CHANGELOG.md
  • CONTRIBUTING.md
  • README.md
  • docs/SOURCES_AND_ENDPOINTS.md
  • pyproject.toml
  • scripts/git/guardrails.sh
  • src/findata/web/templates/docs.html
  • tests/test_api.py

Comment thread docs/SOURCES_AND_ENDPOINTS.md
@robertoecf robertoecf merged commit b244e50 into main May 6, 2026
7 checks passed
@robertoecf robertoecf deleted the codex/objective-readme-source-docs branch May 6, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant