convert Repliear to use the row versioning strategy#158
Open
tantaman wants to merge 25 commits intorocicorp:mainfrom
Open
convert Repliear to use the row versioning strategy#158tantaman wants to merge 25 commits intorocicorp:mainfrom
tantaman wants to merge 25 commits intorocicorp:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on
todo-row-versioning. This won't diff well since it re-structured the app and switched to Vite.Most relevant files:
Meta
Server
Note that past CVRs contribute to the current CVR. I.e., all data the client currently has is represented by all data we've ever sent. If any CVR is dropped we'll just re-fetch the rows that the CVR used to have.
Client
Note that I'm currently only allowing one tab to pull at once. This is explained in
pull.tsin the comment abovedropCVREntries. This is something I could fix if we want to keep the behavior of allowing tabs to sync the same data at the same time.