fix: skip markdown pipeline for whitespace-only text in renderNodes (#143)#144
Merged
fix: skip markdown pipeline for whitespace-only text in renderNodes (#143)#144
Conversation
…#143) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…143) Extend the existing fast path to detect when all text nodes contain only whitespace (indentation, newlines between HTML tags). In this case, skip the micromark + innerHTML + DOM walk pipeline entirely and render nodes directly via renderSingleNode. For a {for} loop over 23 HTML cards, this eliminates ~97 redundant pipeline calls that account for 89% of wall time in Chrome profiles.
|
Release preview: merging this PR will publish v0.43.3 (patch bump from v0.43.2) |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renderNodesfast path to skip the micromark + innerHTML pipeline when all text nodes contain only whitespace (indentation, newlines between HTML tags){for}loops over HTML + macro content, addressing 89% of wall time in Chrome CPU profiles\n\n) detection to maintain paragraph separation semanticsAlso includes (prior work on this branch)
{computed}referencing@loop variable inside{for}causes infinite reactive loop #140)Test plan
tsc --noEmit)🤖 Generated with Claude Code