parth-api-fix#22
Open
ParthAhuja4 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Report
1) Pagination returns the wrong page (fixed)
/tasks?page=1&limit=2should return the first two tasks. Page 2 should return the next two.task-api/src/services/taskService.jsingetPaginated.page * limitinstead of(page - 1) * limit.(page - 1) * limit.2) Status filter matches part of a word (fixed)
/tasks?status=todoshould only return tasks withtodo./tasks?status=dowould match bothtodoanddone.task-api/src/services/taskService.jsingetByStatus.includesinstead of exact match.3) Completing a task resets priority (fixed)
medium.task-api/src/services/taskService.jsincompleteTask.priority: 'medium'every time.4) README status values were wrong (fixed)
README.mdvstask-api/src/utils/validators.js.Coverage Summary
Command used (works on this Windows setup):
Output: