Take-home: tests, bug fixes, and PATCH /tasks/:id/assign#30
Open
tanyyaaa33 wants to merge 2 commits into
Open
Conversation
- Unit tests for taskService and Supertest integration tests for routes - Fix pagination offset and preserve priority on complete (see BUG_REPORT) - PATCH /tasks/:id/assign with validation and tests - Submission notes with coverage summary; PR helper docs Made-with: Cursor
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission notes
Use this text in your PR description or email to the reviewer.
How to run
Coverage
Last run from
task-api(npm run coverage), above the 80% target:What I would test next with more time
page/limit(zero, negative, non-numeric) and consistent error responses across list endpoints.What surprised me
ASSIGNMENT.md/ code (todo,in_progress,donein code and validators).Questions before shipping to production
ETag/ versioning?