My solution#34
Conversation
|
Done |
There was a problem hiding this comment.
Pull request overview
Adds Vercel deployment wiring plus fixes to task listing behavior (status filter + pagination), and introduces an assignee workflow with new endpoint, validators, and test coverage.
Changes:
- Fix status filtering to use exact matches and correct pagination offset / guard invalid paging inputs.
- Add
PATCH /tasks/:id/assignwith request validation and conflict handling for already-assigned tasks. - Add Jest unit + integration tests, plus day summaries and deployment config for Vercel.
Reviewed changes
Copilot reviewed 9 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| task-api/vercel.json | Adds Vercel rewrite to route requests to the serverless entrypoint. |
| task-api/api/index.js | Exposes the Express app as the Vercel function handler. |
| task-api/src/services/taskService.js | Fixes status filtering, fixes pagination, and stores assignee on tasks. |
| task-api/src/utils/validators.js | Adds validateAssignTask and exports it. |
| task-api/src/routes/tasks.js | Adds PATCH /tasks/:id/assign route and wires in new validator. |
| task-api/tests/tasks.routes.test.js | Adds integration tests for tasks routes, including assign/stats/pagination/status filter. |
| task-api/tests/taskService.test.js | Adds unit tests covering service behavior (pagination/status/stats/update/remove/complete). |
| task-api/DAY1_SUMMARY.md | Adds a day-1 testing/coverage summary (currently notes failing tests). |
| task-api/DAY2_SUMMARY.md | Adds a day-2 summary documenting the fixes and the assign endpoint; embeds screenshot. |
| task-api/Screenshot 2026-04-15 165034.png | Adds a screenshot referenced by the day-2 summary. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Day 1 Test and Coverage Summary | ||
|
|
||
| - Command run: npm run coverage | ||
| - Test suites: 2 failed, 2 total | ||
| - Tests: 4 failed, 28 passed, 32 total | ||
|
|
There was a problem hiding this comment.
DAY1_SUMMARY.md currently documents a npm run coverage run with failing test suites/tests. If this file is meant to reflect the current state of the PR, please update it to match the current (passing) results or clearly label it as an historical snapshot to avoid confusing readers/CI triage.
| # Day 1 Test and Coverage Summary | |
| - Command run: npm run coverage | |
| - Test suites: 2 failed, 2 total | |
| - Tests: 4 failed, 28 passed, 32 total | |
| # Day 1 Test and Coverage Summary (Historical Snapshot) | |
| > This file records the Day 1 `npm run coverage` results and bugs found at that time. | |
| > It is a historical snapshot, not the current PR/CI status. | |
| - Command run on Day 1: npm run coverage | |
| - Test suites on Day 1: 2 failed, 2 total | |
| - Tests on Day 1: 4 failed, 28 passed, 32 total |
| 3. Normalization | ||
| - Assignee is stored as trimmed text (`assignee.trim()`). | ||
|
|
||
|  No newline at end of file |
There was a problem hiding this comment.
DAY2_SUMMARY.md embeds a local screenshot file. If you keep screenshots in the repo, consider optimizing/compressing them (or using Git LFS) to avoid large binary files in source control; otherwise link to an external artifact.
|  | |
| Screenshot omitted from the repository to avoid embedding a local binary asset in source control; attach or link it as an external artifact if needed. |
No description provided.