feat: completed take-home assignment#38
Open
HayatAzeem wants to merge 1 commit into
Open
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Submission Notes
What I’d test next if I had more time:
I’d expand testing around edge cases like malformed JSON inputs, tricky date scenarios (such as leap years or missing timezones), and extreme pagination values (e.g., negative pages or very large limits). If this API were backed by a real database, I’d also look into potential race conditions in functions like completeTask and assignTask.
What surprised me in the codebase:
A few implementation details stood out. Using .includes() for exact status matching can introduce subtle bugs, and I noticed that completeTask unintentionally resets task priority. It was also a bit unexpected that app.js executes immediately on import, which makes testing less clean than it could be.
Questions I’d ask before production:
What database are we planning to use, since the current in-memory approach won’t scale or persist data?
Are there any authentication or authorization requirements? Right now, all operations are open.
Should tasks support being unassigned (e.g., assignee: null), and how should validation handle that?