Skip to content

feat: completed take-home assignment#38

Open
HayatAzeem wants to merge 1 commit into
rohit-ups:mainfrom
HayatAzeem:submission-feature-fix
Open

feat: completed take-home assignment#38
HayatAzeem wants to merge 1 commit into
rohit-ups:mainfrom
HayatAzeem:submission-feature-fix

Conversation

@HayatAzeem
Copy link
Copy Markdown

Submission Notes

What I’d test next if I had more time:
I’d expand testing around edge cases like malformed JSON inputs, tricky date scenarios (such as leap years or missing timezones), and extreme pagination values (e.g., negative pages or very large limits). If this API were backed by a real database, I’d also look into potential race conditions in functions like completeTask and assignTask.

What surprised me in the codebase:
A few implementation details stood out. Using .includes() for exact status matching can introduce subtle bugs, and I noticed that completeTask unintentionally resets task priority. It was also a bit unexpected that app.js executes immediately on import, which makes testing less clean than it could be.

Questions I’d ask before production:

What database are we planning to use, since the current in-memory approach won’t scale or persist data?
Are there any authentication or authorization requirements? Right now, all operations are open.
Should tasks support being unassigned (e.g., assignee: null), and how should validation handle that?

@HayatAzeem
Copy link
Copy Markdown
Author

Screenshot 2026-04-16 231902

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant