feat(bank-connector): add connector abstraction, mock implementation, and factory for #266#287
Open
macan88 wants to merge 2 commits intorohitdash08:mainfrom
Open
feat(bank-connector): add connector abstraction, mock implementation, and factory for #266#287macan88 wants to merge 2 commits intorohitdash08:mainfrom
macan88 wants to merge 2 commits intorohitdash08:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There is no abstraction layer for bank integrations, making it impossible to add or swap connectors (import/refresh flows) without touching calling code. Issue #266 requests a connector interface, support for both import and refresh flows, and a mock connector to validate the design.
Solution
Added
app/src/lib/bank-connector.tswhich exports aBankConnectorinterface withimportTransactionsandrefreshTransactionsmethods, aMockBankConnectorthat satisfies the interface with deterministic in-memory data, and acreateConnectorfactory that decouples consumers from concrete implementations. Real connectors (Plaid, Open Banking, etc.) can be added by extending theConnectorNameunion and adding a singlecaseto the factory switch—zero changes required at call sites.Testing
bank-connector.test.tswith three focused cases:sincecursorCloses #266