feat(webhooks): implement signed webhook delivery with retry and dead-letter handling#289
Open
macan88 wants to merge 3 commits intorohitdash08:mainfrom
Open
feat(webhooks): implement signed webhook delivery with retry and dead-letter handling#289macan88 wants to merge 3 commits intorohitdash08:mainfrom
macan88 wants to merge 3 commits intorohitdash08:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The application had no webhook infrastructure — no event emission, signed delivery, retry logic, or subscription management — making external integrations impossible.
Solution
Added
app/src/lib/webhook.tswhich provides the complete webhook event system:HMAC-SHA256over the raw body using a per-subscription secret; consumers verify viaX-Webhook-Signature: sha256=<hex>.idempotency_keyis embedded in every payload and echoed inX-Idempotency-Keyheader so consumers can safely deduplicate retries (at-least-once semantics documented explicitly).payload.version+X-Webhook-Versionheader; non-breaking additions keep1.0, breaking changes bump the version with a migration window.expense.created,expense.updated,expense.deleted,bill.created,bill.paid,settlement.completed.WEBHOOK_EVENTS.mddocuments all event types, payload schema, signature verification, idempotency contract, retry policy, and schema versioning strategy.Testing
failed), stable idempotency key across retries, and subscription auto-disabled after exhaustion.Closes #77