Migrate to using @testing-library/user-event#175
Open
artursvonda wants to merge 1 commit intoromgain:masterfrom
Open
Migrate to using @testing-library/user-event#175artursvonda wants to merge 1 commit intoromgain:masterfrom
artursvonda wants to merge 1 commit intoromgain:masterfrom
Conversation
artursvonda
force-pushed
the
migrate-to-user-event
branch
from
c16cc7c to
f939c81
Compare
Removes redundant `act` calls as well.
artursvonda
force-pushed
the
migrate-to-user-event
branch
from
f939c81 to
f30265f
Compare
|
Love to see this change as it also solves issue with |
|
I've tested these changes locally on a large codebase I'm migrating to React 18 and can confirm it's fixed bugs which arose from the migration |
|
@romgain do you think this can be merged and published to npm? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The userEvent better represents actions taken by user/browser and actually allows us to get rid of some hacks.
Also, testing now with React v18.
And removed redundant act calls as well since, both, fireEvent and userEvent wrap calls in act implicitly (when required).