Skip to content
This repository was archived by the owner on Dec 28, 2019. It is now read-only.

Remove NetBeans project files in favor of gradle files + updated docker#488

Open
kolakcc wants to merge 1 commit into
ronancpl:masterfrom
kolakcc:gradle
Open

Remove NetBeans project files in favor of gradle files + updated docker#488
kolakcc wants to merge 1 commit into
ronancpl:masterfrom
kolakcc:gradle

Conversation

@kolakcc

@kolakcc kolakcc commented Jul 15, 2019

Copy link
Copy Markdown
Contributor
  • Removed included .jar files in favor of dependency managed libaries from Maven.
  • Remove dependency on NetBeans, allowing developers to work with any IDE with gradle support.
  • Remove other methods of building, delegating all builds to gradle using gradlew build.
  • Remove other methods of launching, delegating non-docker runs to gradlew run.
  • Update Docker support to add a docker-compose, which will boot a mysql server as well as the server.
  • Fix Docker image to remove all unnecessary cruft, lowering build times.

Comment thread Dockerfile
RUN sh ./posix-compile.sh
ADD wz ./wz
ADD docker-launch.sh configuration.ini world.ini ./
ADD build/libs/HeavenMS.jar HeavenMS.jar

@xinyifly xinyifly Jul 15, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break the build from a clean clone: build/libs/HeavenMS.jar: no such file or directory

(Maybe you forgot to include ./gradlew build in a multi-stage build?)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./gradlew build shouldn't be included in the image, as it will increase the image size and never cause containers to cache due to non-deterministic gradle builds and cache files. The project should be built out of docker for this reason.

@kolakcc

kolakcc commented Jul 18, 2019

Copy link
Copy Markdown
Contributor Author

I've clarified the instructions, using a29c3bc as a base.

  • Adjust launch.bat to use Gradle. Can you try it out and see if it works? I don't use Windows.
  • Moved instructions about NetBeans to its own section: non-developers on windows ONLY need to hit launch.bat and do not need to fuss with NetBeans and such.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants