perf(map): improve map bundle loading#14
Merged
Conversation
ronload
commented
Apr 15, 2026
ronload
commented
Owner
- perf(map): defer map chunk loading to unblock main thread
- fix(map): resolve react-hooks/set-state-in-effect lint errors
- style: format code style
Mobile/tablet: skip rendering TaiwanMap entirely via JS media query instead of CSS hidden, so the 1MB maplibre-gl chunk is never downloaded. Desktop: show a placeholder first and defer mounting until the main thread is idle (requestIdleCallback with setTimeout fallback for Safari), letting the address form become interactive immediately.
Replace useMediaQuery implementation with useSyncExternalStore to avoid synchronous setState in effect. Remove unnecessary setMapReady reset since the isDesktop guard already prevents map rendering.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.