fix(map): also proxy carto tile shard subdomains#20
Merged
Conversation
Carto distributes tile requests across tiles-a/b/c/d subdomains. These were not caught by the previous proxy rewrite, causing the same http/https CORS mismatch on .mvt tile fetches.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#19 代理了
tiles.basemaps.cartocdn.com,但 Carto 會將 tile 請求分散到tiles-a/tiles-b/tiles-c/tiles-d子網域,這些沒被攔截到,導致.mvttile 仍然出現同樣的 http/https CORS 錯誤。將
proxyCartoUrl改用 regex 匹配tiles(?:-[a-d])?.basemaps.cartocdn.com,統一導到/map-cdn/tiles/代理路徑。Test plan
/map-cdn/tiles/載入