fix(map): resolving map flashing issue by moving neutralization from runtime to build time#22
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolving CartoDB default color schee flashing issue during map loading. By moving map color neutralization to build time.
Change
New
scripts/process-map-styles.ts: ETL script, getting stylesheet from CartoDB and do neutralization.public/data/styles/dark-matter-neutral.json: Dark theme preprocess scheme.public/data/styles/prositron-neutral.json: Light theme preprocess scheme.Modified
scripts/etl.ts: Process map style integration. (pnpm etl)src/components/custom/map.ts: Use local preprocessing style, removeNeutralizaColorscomponent.Deleted
src/lib/map-proxy.ts: Remove functions migrated such asneutalizeMapColors.Commits