Adding 'range' and 'flags' as optional options for specific situations#5
Open
JarKz wants to merge 4 commits intoroobert:mainfrom
Open
Adding 'range' and 'flags' as optional options for specific situations#5JarKz wants to merge 4 commits intoroobert:mainfrom
JarKz wants to merge 4 commits intoroobert:mainfrom
Conversation
Changelog:
- config.lua – refactor unreadable code and adding default range param
- single-buffer.lua - added optional opts param for every function and
refactor some code that links to config.lua
- multi-buffer.lua – same as above (single-buffer.lua)
- visual-multitype.lua - refactor some code that links to config.lua
Changes:
- single-buffer.lua - added or statement in string counting (choice
between opts.flags or config.options.single_buffer.flags). Also
added parentheses for or statement after concats.
- multi-buffer.lua - same as above (but
config.options.multi-buffer.flags)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd read the issue #3 and had thought that make senses.
Now, with this commit, plugins can works normally. And if some peoples want to configure 'range' or 'flags' respectively then they can pass the table like:
There is backward compatibility because param opts are optional and gets form overrided default value by user or default if received param don't exists. Also the README updated, added section for configuring using clear lua and updated configuration.