Fix image artifacts when enabling zoom1#102
Open
abaeyens wants to merge 1 commit into
Open
Conversation
Solves ros-visualization#85 What this fixes: the scaling artefacts are now gone because a true 1-to-1 pixel mapping occurs from image message to the display, without scaling twice in between. What this _probably_ does not fix: the frame size still isn't handled correctly, it just got hidden because got set to zero. I'm afraid it will arise again when people including this code set to a non-zero value. Signed-off-by: Arne Baeyens <mail@arnebaeyens.com>
This was referenced May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #85
What this fixes: the scaling artefacts are now gone because a true 1-to-1 pixel mapping occurs from image message to the display, without scaling twice in between.
What this probably does not fix: the frame size still isn't handled correctly, it just got hidden because got set to zero. I'm afraid it will arise again when people including this code set to a non-zero value.