Skip to content

Deprecate rcpputils::endian#227

Open
mini-1235 wants to merge 4 commits into
ros2:rollingfrom
mini-1235:deprecate_std_endian
Open

Deprecate rcpputils::endian#227
mini-1235 wants to merge 4 commits into
ros2:rollingfrom
mini-1235:deprecate_std_endian

Conversation

@mini-1235
Copy link
Copy Markdown

@mini-1235 mini-1235 commented Apr 19, 2026

Description

Deprecate the rcpputils::endian as we are moving to c++20 and we can use std::endian instead

Fixes # (issue)

Is this user-facing behavior change?

Did you use Generative AI?

No

Additional Information

@mini-1235
Deprecate rcpputils::endian
b21ba90 
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
@mini-1235 mini-1235 mentioned this pull request Apr 19, 2026
Open
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Apr 20, 2026

Pulls: #227
Gist: https://gist.githubusercontent.com/ahcorde/65bef1775b3efb4a3d62b1876c193d38/raw/9b2673419fe4fb43ee75674ff6ee7f3113c4fdf6/ros2.repos
BUILD args: --packages-above-and-dependencies rcpputils
TEST args: --packages-above rcpputils
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19014

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

ahcorde
ahcorde requested changes Apr 23, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflicts

@mini-1235
Merge branch 'rolling' into deprecate_std_endian
8c49f9a 
Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com>
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented May 4, 2026

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

ahcorde
ahcorde requested changes May 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind to fix the issues? https://ci.ros2.org/job/ci_linux/28910/

@mini-1235
Lint
4d54953 
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
@mini-1235
Copy link
Copy Markdown
Author

mini-1235 commented May 7, 2026

@ahcorde done

@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented May 7, 2026 •
edited
Loading

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Jun 2, 2026

Pulls: #227
Gist: https://gist.githubusercontent.com/ahcorde/cdf0b5bb46d2e60e179eaf22b32564bc/raw/9b2673419fe4fb43ee75674ff6ee7f3113c4fdf6/ros2.repos
BUILD args: --packages-above-and-dependencies rcpputils
TEST args: --packages-above rcpputils
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19432

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

ahcorde
ahcorde requested changes Jun 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see some warning on windows. do you mind to take a look ?

@mini-1235
Copy link
Copy Markdown
Author

mini-1235 commented Jun 3, 2026

I can see some warning on windows. do you mind to take a look ?

Are you referring to https://ci.ros2.org/job/ci_windows/28204/testReport/ ?

@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Jun 3, 2026 •
edited
Loading

I can see some warning on windows. do you mind to take a look ?

Are you referring to https://ci.ros2.org/job/ci_windows/28204/testReport/ ?

sorry It wasn't windows, RHEL #warning WARNING: rcpputils/endian.hpp is deprecated. Use std::endian from header instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde requested changes

@mjcarroll mjcarroll mjcarroll approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mini-1235 @ahcorde @mjcarroll @fujitatomoya