Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
==========================================
- Coverage 87.34% 87.10% -0.24%
==========================================
Files 56 56
Lines 4703 4740 +37
Branches 829 831 +2
==========================================
+ Hits 4108 4129 +21
- Misses 379 390 +11
- Partials 216 221 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the node addition and update event emission logic throughout the graph codebase to support batched operations and simplify signal handling. The main change is the introduction and use of new utility functions (
emit_node_added_events,emit_node_updated_events,iter_node_added_events,iter_node_updated_events) that standardize how node events are emitted and processed, allowing for more efficient handling of bulk node operations and improved callback interfaces. Extensive tests have been added to verify correct batched event emission.Event emission refactoring:
emit_node_added_eventsandemit_node_updated_eventsutility functions inbulk_add_nodesandupdate_node_attrsmethods acrossGraphView,RustWorkXGraph, andSQLGraph, ensuring consistent and batched event emission. [1] [2] [3] [4] [5] [6] [7]Callback interface and batch processing:
GraphArrayand spatial filter classes to process batched node addition and update events usingiter_node_added_eventsanditer_node_updated_events, improving efficiency and correctness for bulk operations. [1] [2] [3] [4] [5] [6] [7]Testing improvements:
Minor fixes:
update_node_attrsmethods for consistency. [1] [2]