Ensure unique roots for lineage extraction#253
Merged
JoOkuma merged 2 commits intoroyerlab:mainfrom Jan 28, 2026
Merged
Conversation
The function splits correctly cell lineages. However, roots are duplicated (because cells with parent_track_id == NO_PARENT) are present at various times, which are all kept in the roots array. Substituting "to_numpy" to "unique" fixes this issue.
Member
|
@cairola, that makes sense, thanks for catching this. |
Member
|
Once I fix the CI in #254 I'll merge your PR |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #253 +/- ##
=======================================
Coverage ? 83.12%
=======================================
Files ? 97
Lines ? 6212
Branches ? 0
=======================================
Hits ? 5164
Misses ? 1048
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function splits correctly cell lineages. However, roots are duplicated (because cells with parent_track_id == NO_PARENT) are present at various times, which are all kept in the roots array. Substituting "to_numpy" to "unique" fixes this issue.