Conversation
JoOkuma
approved these changes
Feb 11, 2026
Member
JoOkuma
left a comment
JoOkuma
left a comment
There was a problem hiding this comment.
@TeunHuijben LGTM! Thanks for adding the test case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... when nodeDB.pickle only has mask and bbox
In Ultrack, the NodeDB.pickle always contains the entire
Node, including thenode_id, so this is not a problem.However, in our "manual" cases, the pickle only contains the
maskandbbox. In this case, the_add_overlapsgives the wrongancestor_id(-1), because the pickle doesn't contain thenode_id.This PR makes a slight change to
_add_overlapsto ensure theancestor_idinoverlapDBis correct.The new test tests this by making a minimal node class in which the pickle doesn't contain the
node_id