Skip to content

feat: enhance AskUserQuestion enforcement and improve recovery features#51

Merged
benym merged 5 commits into
masterfrom
dev
May 29, 2026
Merged

feat: enhance AskUserQuestion enforcement and improve recovery features#51
benym merged 5 commits into
masterfrom
dev

Conversation

@benym
Copy link
Copy Markdown
Contributor

@benym benym commented May 29, 2026 •
edited
Loading

✨ Summary

🎯 Scope

  • CLI commands (init, status, doctor, update)
  • Core installer / platform detection
  • Comet skills (assets/skills/, assets/skills-zh/)
  • Comet shell scripts (assets/skills/comet/scripts/)
  • Tests / CI
  • Documentation / changelog
  • Other:

🧪 Testing

  • pnpm build
  • pnpm lint
  • pnpm format:check
  • pnpm test
  • pnpm test -- test/ts/comet-scripts.test.ts
  • pnpm test:shell
  • Not run:

✅ Checklist

  • PR title follows Conventional Commits, for example fix: handle project-scope init
  • User-facing behavior is documented in README.md, README-zh.md, or CONTRIBUTING.md
  • CHANGELOG.md is updated when behavior changes
  • Skill changes were made in Chinese first when applicable, then synced to English
  • New scripts are included in assets/manifest.json and relevant tests
  • Shell scripts remain portable across macOS, Linux, and Windows Git Bash
  • No unrelated generated files or local artifacts are included

👀 Notes for Reviewers

benym added 2 commits May 29, 2026 18:06
@benym
chore: update changelog and version to 0.3.4
e24bea9
@benym
feat: add AskUserQuestion enforcement, context recovery, and robustne…
f418be8 
…ss fixes

- Add check --recover to comet-state.sh for structured compaction recovery
- Add field_status() helper for DONE/PENDING/BROKEN field reporting
- Fix unbound variable crash when tasks.md missing under set -u
- Fix path truncation risk with spaces in design_doc field
- Unify direct_override fallback style to || true
- Enforce AskUserQuestion tool at all 21 decision points across 7 skills
- Add red flags table, uncertainty weighting, naming guard, file verification
- Add idempotency notes and compaction recovery sections to all phases
- Sync all 14 zh/en skill files to full parity
- Add 8 test cases for check --recover covering all phases
- Bump version to 0.3.5
gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 29, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a context compaction recovery feature (--recover) to the comet-state check command, allowing agents to resume progress from structured recovery contexts across different phases. It updates the corresponding English and Chinese skill guides to detail idempotency, decision-point guards (enforcing the use of AskUserQuestion), and a new 'Red Flags' checklist. Additionally, comprehensive tests are added to validate the recovery logic. The review feedback highlights two issues in the recovery script: an inconsistency in trailing-space stripping for the design_doc path check, and a misleading recovery message in the verification phase when verification has passed but branch handling is still pending.

Comment thread assets/skills/comet/scripts/comet-state.sh Outdated
Comment thread assets/skills/comet/scripts/comet-state.sh
benym added 3 commits May 30, 2026 00:08
@benym
Merge branch 'master' into dev
71fba3e 
# Conflicts:
#	CHANGELOG.md
#	package-lock.json
#	package.json
@benym
fix: address PR review feedback for comet-state recover
12cd7d6 
- Remove inconsistent trailing-space stripping in design_doc field_status call
- Add explicit elif for verify_result=pass with pending branch_status
  to avoid misleading 'not yet started' recovery message
@benym
fix: update skills.test.ts assertions to match AskUserQuestion wording
0e359cf 
All skill files were updated to require AskUserQuestion tool explicitly,
but skills.test.ts still expected the old text without AskUserQuestion.
Updated 12 assertions across zh/en to match the new wording.
@benym benym merged commit d6b471a into master May 29, 2026
13 checks passed
chentao326 pushed a commit to chentao326/comet that referenced this pull request May 29, 2026
fix: merge upstream AskUserQuestion enforcement + Red Flags into auto…
6a15261 
…-pilot

Port PR rpamis#51 enhancements:
- Add AskUserQuestion tool requirement to decision point descriptions
- Add Red Flags table (ZH: 红旗清单) for agent psychology pitfalls
- Add 'open phase' as decision point rpamis#1
- Add 'no text output substitute for tool waiting' enforcement rule
chentao326 pushed a commit to chentao326/comet that referenced this pull request May 30, 2026
fix: prettier formatting + AskUserQuestion enforcement in design skills
6b964ed 
- Run prettier on src/commands/auto.ts to fix CI format check
- Add 'AskUserQuestion tool' to design confirmation enforcement text
  in both ZH and EN comet-design skill files to match PR rpamis#51 test expectations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@benym