feat: add lightweight verification review#52
Closed
ddddddddwp wants to merge 1 commit into
Closed
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a lightweight verification review step to the comet-verify skill, requiring a scoped code review focused on correctness, security, and edge cases while skipping deeper checks like spec coverage or design doc consistency. These updates are reflected in both the English and Chinese skill documentation, the changelog, and verified with new test assertions. Feedback on the changes suggests capitalizing the first letter of the newly added list item in the English skill documentation for consistency.
| 3. Build passes (run project-specific build command, e.g., `npm run build`, `mvn compile`, `cargo build`, etc.) | ||
| 4. Related tests pass | ||
| 5. No obvious security issues (no hardcoded keys, no new unsafe operations) | ||
| 6. lightweight code review passes: dispatch a code-reviewer subagent that checks only correctness, security, and edge cases |
Contributor
There was a problem hiding this comment.
For consistency with the other list items in this section, capitalize the first letter of the item.
Suggested change
| 6. lightweight code review passes: dispatch a code-reviewer subagent that checks only correctness, security, and edge cases | |
| 6. Lightweight code review passes: dispatch a code-reviewer subagent that checks only correctness, security, and edge cases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
npx vitest run test/ts/skills.test.tsgit diff --check origin/master..HEADNotes
npx vitest runcurrently fails intest/ts/init-e2e.test.tsbecause the clean-directory init fixture cannot find.claude/skillsin the temporary home.