add threshold-uncovered option#173
Open
guyfedwards wants to merge 1 commit into
Open
Conversation
guyfedwards
force-pushed
the
add-threshold-uncovered
branch
from
5cca005 to
5c853d6
Compare
allows threshold to be set by number of uncovered lines instead of percentage of coverage. In a codebase which continuously grows, if you fix the number of lines uncovered then you (loosely) enforce that all new code should be covered. closes rpl#168
guyfedwards
force-pushed
the
add-threshold-uncovered
branch
from
5c853d6 to
ee62702
Compare
|
wow that's nice! 🎉 It is super useful when your app has really good coverage, in my case we have:
It means someone can push something with ~200 untyped lines and the coverage won't drop. I could use decimals and get more precise with the required coverage but that PR sounds like a better solution |
|
@rpl Do you think you can take a look at this? This would be nice to get merged. |
|
Bump? 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allows threshold to be set by number of uncovered lines instead of percentage
of coverage.
In a codebase which continuously grows, if you fix the number of lines uncovered
then you (loosely) enforce that all new code should be covered.
closes #168