keras model_file expects str instead of Path. fixes #9#22
Closed
mbhall88 wants to merge 1 commit intorrwick:masterfrom
mbhall88:master
Closed
keras model_file expects str instead of Path. fixes #9#22mbhall88 wants to merge 1 commit intorrwick:masterfrom mbhall88:master
mbhall88 wants to merge 1 commit intorrwick:masterfrom
mbhall88:master
Conversation
Author
|
fixed in e053457. PR no longer required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am aware that #10 already addresses this issue. However, the way that PR goes about fixing the problem in #9 (in my opinion) is not ideal.
load_modelexpects astror "h5py.File or h5py.Group object from which to load the model". @rrwick handles the model files internally with thepathlib.Pathclass which is an obvious design choice as these objects are indeed paths and therefore the added functionality this class brings within python is something Ryan uses a lot in the code.I don't think changing the function
find_modelto return astrinstead of aPathto satisfy the single use ofkeras.load_modelis warranted.