Final cleanups before version 2 can be released.#30
Conversation
This removes the dependency from the package, since now we're requiring Python 3.5 anyway.
Note that the package_data entries were not actually in use: those files are top-level rather than part of a package, so the resulting distribution is identical.
|
@rshk I'll leave to you to merge this one, and do the tag/release dance if you have a moment — I think we're in a good place for releasing version 2.0.0, Python 3 only and with write support. |
|
https://github.com/Flameeyes/usbmon-tools/tree/pcapngwrite is a practical test case for this one. |
Revert the name change to underscore, but keep the rest. Note that this removes CHANGELOG.rst from the PyPI descriptor, which is probably correct.
|
Hm the failure with Travis CI is because I guess we could remove it from 3.5. |
This is reported by the newer versions of flake8.
The pytest-pycodestyle package is now a Python 3.6+ dependency, so it will fail on 3.5. But even so, we don't need it, as flake8 (already ran as part of pre-commit) already runs codestyle.
|
@rshk can you please take a look? Or should I just merge this by Tuesday if you don't object? :) |
|
Looks good 👍 anything in particular you want me to look at? Happy to to merge otherwise. Is this the last PR before a 2.0 release? |
I think it should be, yes. Adding typing (#32) is probably worth keeping on a follow up release, so that users can keep this version until.they fix up their callsites. Would you like to do the honours for a release? 😄 |
2 participants
This cleans up a bit after
setup.py, and removes thesixdependency that is now unneeded.