Fix throwing exceptions under Emscripten#155
Merged
cpsievert merged 2 commits intorstudio:mainfrom Jun 30, 2025
Merged
Conversation
Contributor
Author
|
cc @gadenbuie @wch Tagging @cpsievert for review. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, C++ exceptions are disabled in Emscripten. They are opt-in by setting a particular flag at compile and link time.
The webR R package cross-compiler, {rwasm}, adds the required flag at link time, but we also need to provide it at compile time when building
libsass. This PR makes that change.Fixes r-wasm/webr#525.