Update helpers.py#299
Conversation
|
Hey @CH-GAGANRAJ this looks too good to be true! Thanks for making the effort to fix this! When i try it (on Windows 11) Iget the following: |
|
I played around with this a bit and it looks like there are MANY more changes needed to get things working in windows. |
|
Thanks for testing this on Windows 11, @meichthys! I appreciate the feedback. You're right that there are likely many more changes needed for full Windows support - this PR just tackles one specific piece of that puzzle. Create separate issues for the other Windows compatibility problems you've found? Let me know if the changes I made in helpers.py specifically are causing any issues, and I'm happy to address those! |
|
It may be helpful to track all of the issues, however, since this would be such a large undertaking, I think we would need input from the maintainers first since none of these fixes accomplish anything until the whole windows compatibility issue is resolved. |
Fix : Does not work on Windows as there is a dependency on grp #289
Fix: Skip grp import on Windows to enable cross-platform CLI usage
PR Description:
This patch improves cross-platform compatibility by conditionally importing the Unix-only grp module in helpers.py. On Windows systems, the CLI previously failed due to ImportError. This fix:
This allows the CLI to run natively on Windows without crashing, while preserving full functionality on Unix-based systems.
Let me know if you'd prefer a fallback behavior or stricter handling. Happy to iterate!