Skip to content

chore: update minimatch js package to 10.2.4#2314

Closed
mi5t4n wants to merge 1 commit intodevelopfrom
chore/update-minimatch-js-package-to-10.2.4
Closed

chore: update minimatch js package to 10.2.4#2314
mi5t4n wants to merge 1 commit intodevelopfrom
chore/update-minimatch-js-package-to-10.2.4

Conversation

@mi5t4n
Copy link
Member

@mi5t4n mi5t4n commented Mar 5, 2026

This PR updates minimatch js package to ^10.2.4 using overrides.

Copilot AI review requested due to automatic review settings March 5, 2026 05:31
@mi5t4n mi5t4n self-assigned this Mar 5, 2026
@gemini-code-assist
Copy link

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the minimatch dependency version used by the Playwright E2E test package via npm overrides, and refreshes the lockfile to match.

Changes:

  • Bumps the npm overrides entry for minimatch to ^10.2.4.
  • Updates package-lock.json to resolve minimatch@10.2.4 (including updated tarball integrity/metadata).

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
tests/wp-e2e-playwright/package.json Updates minimatch override to target newer 10.2.4 release.
tests/wp-e2e-playwright/package-lock.json Locks minimatch resolution to 10.2.4 with updated package metadata.
Files not reviewed (1)
  • tests/wp-e2e-playwright/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"overrides": {
"webpack-dev-server": "5.2.1",
"minimatch": "10.2.1",
"minimatch": "^10.2.4",
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the overrides block, every other dependency is pinned to an exact version, but minimatch is now a semver range (^10.2.4). Using a range here makes installs less deterministic when the lockfile is regenerated and weakens the intent of an override (pinning a transitive dependency to a specific known-good version). Consider pinning minimatch to an exact version (e.g., 10.2.4) to match the rest of this file, unless there’s a specific reason to allow automatic minor updates.

Suggested change
"minimatch": "^10.2.4",
"minimatch": "10.2.4",

Copilot uses AI. Check for mistakes.
@mi5t4n
Copy link
Member Author

mi5t4n commented Mar 5, 2026

Resolved by #2313

@mi5t4n mi5t4n closed this Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants