Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
There was a problem hiding this comment.
Pull request overview
Updates dependency resolution in the Playwright E2E test package to ensure a newer svgo version is used (via npm overrides), and also bumps @wordpress/scripts.
Changes:
- Bump
@wordpress/scriptsfrom^31.5.0to^31.6.0 - Add an npm
overridesentry forsvgotargeting^3.3.3
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "ajv": "8.18.0", | ||
| "basic-ftp": "5.2.0" | ||
| "basic-ftp": "5.2.0", | ||
| "svgo": "^3.3.3" |
There was a problem hiding this comment.
overrides entries in this file are pinned to exact versions, but svgo is set to a caret range (^3.3.3). Using a range weakens the purpose of an override (you may unexpectedly pick up future 3.x releases) and is inconsistent with the other overrides here; consider pinning to an exact 3.3.3 version instead.
| "svgo": "^3.3.3" | |
| "svgo": "3.3.3" |
| "@octokit/core": "^7.0.6", | ||
| "@octokit/plugin-paginate-rest": "^14.0.0", | ||
| "@wordpress/scripts": "^31.5.0", | ||
| "@wordpress/scripts": "^31.6.0", |
There was a problem hiding this comment.
Bumping @wordpress/scripts to ^31.6.0 should be reflected in the PR description (currently it says this PR only updates svgo via overrides). Either mention this additional dependency upgrade in the description or split it into a separate PR to keep the change focused.
| "@octokit/core": "^7.0.6", | ||
| "@octokit/plugin-paginate-rest": "^14.0.0", | ||
| "@wordpress/scripts": "^31.5.0", | ||
| "@wordpress/scripts": "^31.6.0", |
There was a problem hiding this comment.
After upgrading to @wordpress/scripts@31.6.0, the dependency tree requires Node >=18.12.0 (per the package's engines in the lockfile). This package.json still declares engines.node as >=12, which is misleading and can cause install/CI failures in environments that enforce engines; update the engines field to match the actual minimum supported Node version.
|
Resolved by #2313 |
This PR updates
svgojs pacakge to^3.3.3usingoverrides.