Skip to content

chore: update svgo js package to 3.3.3#2315

Closed
mi5t4n wants to merge 1 commit intodevelopfrom
chore/update-svgo-js-package-to-3.3.3
Closed

chore: update svgo js package to 3.3.3#2315
mi5t4n wants to merge 1 commit intodevelopfrom
chore/update-svgo-js-package-to-3.3.3

Conversation

@mi5t4n
Copy link
Member

@mi5t4n mi5t4n commented Mar 5, 2026

This PR updates svgo js pacakge to ^3.3.3 using overrides.

@mi5t4n mi5t4n self-assigned this Mar 5, 2026
Copilot AI review requested due to automatic review settings March 5, 2026 05:39
@gemini-code-assist
Copy link

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates dependency resolution in the Playwright E2E test package to ensure a newer svgo version is used (via npm overrides), and also bumps @wordpress/scripts.

Changes:

  • Bump @wordpress/scripts from ^31.5.0 to ^31.6.0
  • Add an npm overrides entry for svgo targeting ^3.3.3

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"ajv": "8.18.0",
"basic-ftp": "5.2.0"
"basic-ftp": "5.2.0",
"svgo": "^3.3.3"
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overrides entries in this file are pinned to exact versions, but svgo is set to a caret range (^3.3.3). Using a range weakens the purpose of an override (you may unexpectedly pick up future 3.x releases) and is inconsistent with the other overrides here; consider pinning to an exact 3.3.3 version instead.

Suggested change
"svgo": "^3.3.3"
"svgo": "3.3.3"

Copilot uses AI. Check for mistakes.
"@octokit/core": "^7.0.6",
"@octokit/plugin-paginate-rest": "^14.0.0",
"@wordpress/scripts": "^31.5.0",
"@wordpress/scripts": "^31.6.0",
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping @wordpress/scripts to ^31.6.0 should be reflected in the PR description (currently it says this PR only updates svgo via overrides). Either mention this additional dependency upgrade in the description or split it into a separate PR to keep the change focused.

Copilot uses AI. Check for mistakes.
"@octokit/core": "^7.0.6",
"@octokit/plugin-paginate-rest": "^14.0.0",
"@wordpress/scripts": "^31.5.0",
"@wordpress/scripts": "^31.6.0",
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After upgrading to @wordpress/scripts@31.6.0, the dependency tree requires Node >=18.12.0 (per the package's engines in the lockfile). This package.json still declares engines.node as >=12, which is misleading and can cause install/CI failures in environments that enforce engines; update the engines field to match the actual minimum supported Node version.

Copilot uses AI. Check for mistakes.
@mi5t4n
Copy link
Member Author

mi5t4n commented Mar 5, 2026

Resolved by #2313

@mi5t4n mi5t4n closed this Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants