Skip to content

chore: update fast-xml-parser js package to ^5.3.9#2316

Closed
mi5t4n wants to merge 1 commit intodevelopfrom
chore/update-fast-xml-parser-js-package-to-5.3.9
Closed

chore: update fast-xml-parser js package to ^5.3.9#2316
mi5t4n wants to merge 1 commit intodevelopfrom
chore/update-fast-xml-parser-js-package-to-5.3.9

Conversation

@mi5t4n
Copy link
Member

@mi5t4n mi5t4n commented Mar 5, 2026

This PR updates fast-xml-parser js package to ^5.3.9

Resolves https://github.com/rtCamp/rtMedia/security/dependabot/123

Copilot AI review requested due to automatic review settings March 5, 2026 05:42
@mi5t4n
Copy link
Member Author

mi5t4n commented Mar 5, 2026

Closes by #2313

@mi5t4n mi5t4n closed this Mar 5, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the tests/wp-e2e-playwright dependency override for fast-xml-parser to address the linked Dependabot security alert, and refreshes the lockfile accordingly.

Changes:

  • Bump fast-xml-parser override in tests/wp-e2e-playwright/package.json to ^5.3.9.
  • Update tests/wp-e2e-playwright/package-lock.json to resolve fast-xml-parser to 5.4.2 and include its new dependency fast-xml-builder.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
tests/wp-e2e-playwright/package.json Updates the overrides entry for fast-xml-parser.
tests/wp-e2e-playwright/package-lock.json Reflects the new resolved fast-xml-parser version and adds fast-xml-builder.
Files not reviewed (1)
  • tests/wp-e2e-playwright/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"webpack-dev-server": "5.2.1",
"minimatch": "10.2.1",
"fast-xml-parser": "5.3.7",
"fast-xml-parser": "^5.3.9",
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this package's overrides block, all other overrides are pinned to exact versions, but fast-xml-parser is now a caret range (^5.3.9). This can cause the override target to drift on future installs and makes the lockfile version (currently 5.4.2) harder to reason about. Consider pinning fast-xml-parser to a specific version (e.g., the resolved 5.4.2, or at least an exact 5.3.9) to keep overrides deterministic and consistent with the rest of this file.

Suggested change
"fast-xml-parser": "^5.3.9",
"fast-xml-parser": "5.4.2",

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants