Open
Conversation
6dda94e to
3bd7337
Compare
3bd7337 to
4cbfd4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Visual parity with shadcn/ui Combobox.
Description
Complete visual revamp of the Combobox component to match shadcn/ui design. This includes new trigger modes, chips for multiple selection, keyboard navigation, and accessibility improvements.
What's new
ComboboxInputTrigger— New default trigger: an input field that doubles as the search box. Replaces the button-style trigger as the primary combobox pattern.ComboboxBadgeTrigger— Multiple selection trigger with inline chips/badges. Selected items appear as removable chips inside the input field. Supportsclear_button: trueprop.ComboboxItemIndicator— Check icon (✓) on the right side of selected items, usingpeer-checked:opacity-100CSS pattern.ComboboxBadge— Chip component for badges inside the trigger.size-6 rounded-sm hover:bg-muted).What changed (non-breaking)
ComboboxItem— Removedhas-[:checked]:bg-accent(no persistent background on selected items, only check icon). Removedaria-[current=true]:ring(no ring on keyboard highlight, only bg-accent).ComboboxRadio/ComboboxCheckbox— Now peer sr-only (visually hidden, accessible).ComboboxTrigger(Popup mode) — Placeholder text now uses text-muted-foreground and switches to foreground when an item is selected.ComboboxClearButton— Subtle gray styling, added focus-visible:ring-2 for keyboard accessibility.ComboboxPopover— Removed autofocus attribute (focus stays on trigger/input).API compatibility
No breaking changes. All existing APIs continue to work. New features are additive:
ComboboxBadgeTrigger(clear_button: true)— new prop, defaults to falseComboboxInputTrigger— new component, existing ComboboxTrigger still worksComboboxItemIndicator— auto-rendered by ComboboxItem, no user action neededTailwind only
Zero inline CSS. All styling via Tailwind classes. JS-toggled classes (h-auto, min-h-9, pt-1.5) are referenced in Ruby comments so Tailwind compiles them.
Testing instructions
bundle exec rake— 103 tests, 450 assertions, 0 failures