fix: bottom position gap between float and status line#3
Open
delphinus wants to merge 2 commits intoruicsh:mainfrom
Open
fix: bottom position gap between float and status line#3delphinus wants to merge 2 commits intoruicsh:mainfrom
delphinus wants to merge 2 commits intoruicsh:mainfrom
Conversation
When position = "bottom" with both a tabline and a status line visible, a 1-row gap of the underlying editor content appears between the floating terminal and the status line. The SW anchor treats row as an exclusive boundary — the float occupies up to row - 1. The row was set to editor_height, which subtracts rows for both the tabline and the status line. The tabline subtraction shifted the float's bottom edge upward, creating a gap between the float and the status line. Add the status line row back to the SW anchor position (editor_height + 1). The float height calculation still uses editor_height unchanged.
Owner
|
hey @delphinus thanks, there's some tests failing, can you fix them, or adapt to your new code, please? |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Author
|
Hi, I did a fix for tests. Check it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When position = "bottom" with both a tabline and a status line visible, a 1-row gap of the underlying editor content appears between the floating terminal and the status line (as screenshots below).
Reproducible init.lua
This diff adds the status line row back to the SW anchor position (
editor_height+ 1). The calculation for floating terminals still useseditor_heightunchanged.