Skip to content

fix: bottom position gap between float and status line#3

Open
delphinus wants to merge 2 commits intoruicsh:mainfrom
delphinus:fix/bottom-position-gap
Open

fix: bottom position gap between float and status line#3
delphinus wants to merge 2 commits intoruicsh:mainfrom
delphinus:fix/bottom-position-gap

Conversation

@delphinus
Copy link
Copy Markdown

When position = "bottom" with both a tabline and a status line visible, a 1-row gap of the underlying editor content appears between the floating terminal and the status line (as screenshots below).

スクリーンショット 2026-03-22 14 48 27
Reproducible init.lua
vim.o.laststatus = 2
vim.o.showtabline = 2

local lazypath = vim.fn.stdpath "data" .. "/lazy/lazy.nvim"
if vim.uv.fs_stat(lazypath) then
  vim.opt.rtp:prepend(lazypath)
else
  load(vim.fn.system "curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua")()
end

require("lazy").setup {
  {
    "ruicsh/termite.nvim",
    commit = "60184a1eaec3bf3f8f404eed4ee69b30f38cfe54",
    opts = {
      position = "bottom",
      wo = {
        signcolumn = "yes:1",
        winblend = 30,
      },
    },
  },
}

This diff adds the status line row back to the SW anchor position (editor_height + 1). The calculation for floating terminals still uses editor_height unchanged.

When position = "bottom" with both a tabline and a status line visible,
a 1-row gap of the underlying editor content appears between the
floating terminal and the status line.

The SW anchor treats row as an exclusive boundary — the float occupies
up to row - 1. The row was set to editor_height, which subtracts rows
for both the tabline and the status line. The tabline subtraction
shifted the float's bottom edge upward, creating a gap between the
float and the status line.

Add the status line row back to the SW anchor position
(editor_height + 1). The float height calculation still uses
editor_height unchanged.
@ruicsh
Copy link
Copy Markdown
Owner

ruicsh commented Mar 23, 2026

hey @delphinus thanks, there's some tests failing, can you fix them, or adapt to your new code, please?

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@delphinus
Copy link
Copy Markdown
Author

Hi, I did a fix for tests. Check it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants