feat(listReservations): lock in expires_*/finalized_* window passthrough (0.2.4)#79
Merged
Conversation
…ugh (0.2.4) Client-side companion to cycles-protocol-v0.yaml revision 2026-05-22 (runcycles/cycles-protocol#98) and runcycles/cycles-server#163. Closes the Spring Boot starter side of issue #162. Follow-up to v0.2.3 with the same shape, just four more params. The existing `DefaultCyclesClient.listReservations(Map<String, String>)` signature already forwards arbitrary keys to the URL query string, so the four new ISO 8601 date-time params (expires_from / expires_to / finalized_from / finalized_to) work over the wire today without a code change. This commit adds a regression test on DefaultCyclesClientTest$ListReservations that pins all four params on the wire under their spec-mandated names. Spring's WebClient leaves colons unencoded in the query component (RFC 3986 §3.4-valid), so the wire form is expires_from=2026-05-22T00:00:00Z — same shape as v0.2.3 for from/to. No protocol or wire-format change; servers older than v0.1.25.21 silently ignore the new params per the additive-parameter guarantee. 434 tests pass; JaCoCo coverage gate met. Bumped to 0.2.4 via the single .mvn/maven.config source of truth (propagates to both cycles-client-java-spring and cycles-demo-client-java-spring poms in lockstep — drift-protection from the CI-friendly versions refactor).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Client-side companion to cycles-protocol-v0.yaml revision 2026-05-22 and cycles-server#163. Closes the Spring Boot starter side of runcycles/cycles-server#162. Same shape as v0.2.3.
What this PR does
DefaultCyclesClient.listReservations(DefaultCyclesClientTest$ListReservations.shouldForwardExpiresAndFinalizedWindows) confirming the four new ISO-8601 window params land on the wire. The existingMap<String, String>signature already accepts them..mvn/maven.config(propagates to both starter + demo poms).AUDIT.mdandCHANGELOG.md.No production code change.
Wire-format note
Spring's
WebClientleaves colons unencoded in the query component (RFC 3986 §3.4-valid), so the emitted path is e.g.expires_from=2026-05-22T00:00:00Z— same convention as v0.2.3 forfrom/to.Verification
mvn -B verify --file cycles-client-java-spring/pom.xml: 434 tests pass.Test plan