Added docker-run-remote-script-node-step#74
Open
ArtemVdovyk wants to merge 1 commit into
Open
Conversation
Added possibility to run docker image on the remote node
There was a problem hiding this comment.
Pull request overview
This PR adds a new Rundeck step provider intended to run the existing run-image script on a remote node (as opposed to the existing local/workflow node step), enabling docker run to be executed on the target node.
Changes:
- Added a new provider
docker-run-remote-script-node-stepusingRemoteScriptNodeStep. - Reused the existing
run-imagescript and exposed the same set of Docker run options via step configuration.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| - type: String | ||
| name: cidfile | ||
| title: "cidfile" | ||
| description: "Write the container ID to the file" |
Comment on lines
+592
to
+597
| title: docker / image / run / remote node | ||
| description: "Run the image and execute command" | ||
| plugin-type: script | ||
| script-interpreter: python -u | ||
| script-file: run-image | ||
| script-args: ${config.image} ${config.command} |
Comment on lines
+593
to
+597
| description: "Run the image and execute command" | ||
| plugin-type: script | ||
| script-interpreter: python -u | ||
| script-file: run-image | ||
| script-args: ${config.image} ${config.command} |
Comment on lines
+631
to
+635
| name: volumes-from | ||
| title: "volumes-from" | ||
| description: "Mount volumes from the specified container(s)" | ||
| renderingOptions: | ||
| groupName: "Container" |
| - type: String | ||
| name: env-file | ||
| title: "file with environment variables" | ||
| description: "Set path of file with environment variables (in the filesystem where Rundeck runs)." |
Contributor
|
@ArtemVdovyk - Sorry it took us so long to reply, but this looks like a great PR. If you are able to address the feedback from CoPilot we can then merge into a local branch and take it from there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added possibility to run docker image on the remote node.