Merged
Conversation
…edentials and enhance task tagging. Refactor runbooks and SLIs to include 'data:config' tags for better categorization. Remove direct access to AWS access keys in favor of a more secure environment-based approach.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| ${AWS_SECRET_ACCESS_KEY}= RW.Core.Import Secret AWS_SECRET_ACCESS_KEY | ||
| ... type=string | ||
| ... description=AWS Access Key Secret | ||
| ... description=AWS credentials from the workspace (from aws-auth block; e.g. aws:access_key@cli, aws:irsa@cli). |
There was a problem hiding this comment.
AWS credentials pattern rejects valid auth values
High Severity
RW.Core.Import Secret now reads aws_credentials, but validation still uses pattern=\w*. The documented credential formats (like aws:access_key@cli or aws:irsa@cli) include : and @, so valid aws_credentials values can be rejected during suite initialization, preventing the runbook from executing.
Additional Locations (2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Update AWS health codebundles to use environment variables for AWS credentials and enhance task tagging. Refactor runbooks and SLIs to include 'data:config' tags for better categorization. Remove direct access to AWS access keys in favor of a more secure environment-based approach.
Note
Medium Risk
Touches authentication wiring across many runbooks/SLIs; misconfiguration of the new
aws-auth/env-based setup could break AWS access at runtime, though business logic is otherwise unchanged.Overview
Refactors the AWS c7n health codebundles (ACM, EBS, EC2, Monitoring, Network, RDS, S3) to stop passing
AWS_ACCESS_KEY_ID/AWS_SECRET_ACCESS_KEYintoRW.CLI.Run Cliand instead use a suite-level&{env}plus a single importedaws_credentialssecret.Updates SLI/Runbook templates to replace explicit access-key secrets with
{% include "aws-auth.yaml" ignore missing %}, and adds thedata:configtag across tasks for improved categorization/metadata. Bumpsrw-cli-keywordsfrom0.0.19to0.0.27.Written by Cursor Bugbot for commit 3b2e234. This will update automatically on new commits. Configure here.