Merged
Conversation
- Add .devcontainer/Dockerfile that patches /usr/lib/os-release and /etc/os-release to bookworm before docker-in-docker runs (works even when GHCR :latest is stale). - Switch devcontainer.json from image to build using that Dockerfile. - Mirror the same normalization in the repo root Dockerfile for CI builds. Made-with: Cursor
Drop .devcontainer/Dockerfile and restore image: in devcontainer.json. os-release normalization stays in the root Dockerfile (built by Actions). Made-with: Cursor
- Added .cursor/rules/ to .gitignore to prevent committing generated Cursor rules. - Updated README to clarify the location of installed skills and the symlink for codecollection. - Modified Taskfile to create a symlink for codecollection during setup and improved messaging for clarity. - Removed the on-create.sh script as its functionality is now handled by Taskfile. These changes enhance the developer experience by streamlining the setup process and providing clearer instructions.
- Updated Dockerfile to create the .ssh directory and set appropriate permissions for SSH access. - Added a postCreateCommand in devcontainer.json to ensure the .ssh directory and authorized_keys file are created with correct permissions automatically. - Revised documentation to clarify that SSH permission errors should not occur due to these automated setups. These changes improve the security and usability of the development environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.