Cleans up global nodeselector and tolerations configs#75
Open
stewartshea wants to merge 2 commits intomainfrom
Open
Cleans up global nodeselector and tolerations configs#75stewartshea wants to merge 2 commits intomainfrom
stewartshea wants to merge 2 commits intomainfrom
Conversation
…tion for runner workloads in values.yaml and runner-configmap.yaml.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
…opy for improved stability and merge order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Changes Helm-generated runner scheduling by merging global and deployment
nodeSelectorvalues and removes therunEnvironment.podconfiguration block, which could alter where runner workloads land or break setups relying on the old pod-level settings.Overview
Bumps the
runwhen-localHelm chart version to0.5.1.Updates the runner config templating so runner deployments inherit the global
nodeSelector(merged withrunner.runEnvironment.deployment.nodeSelector) and removes therunEnvironment.pod/TaskSet pod configuration section from the generatedrunner-configConfigMap. Correspondingvalues.yamldocs are cleaned up to reflect that runner workloads are configured via the deployment settings only.Written by Cursor Bugbot for commit 8b64c1b. This will update automatically on new commits. Configure here.