Conversation
…ng. Removed redundant issue logging for non-numeric outputs and command failures, defaulting to 0 for invalid metrics. This change enhances clarity and reduces unnecessary complexity in error handling.
…ort data. Updated methods in runbook.robot and DynamicIssues.py to include optional report data (stdout, stderr, history) when creating issues. This improves the clarity and context of generated issues, facilitating better debugging and tracking.
…tained a user-provided script execution task with environment variable support, which is no longer needed. The removal enhances clarity and reduces complexity in the project.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
…eneration. Removed conditional checks for report data preparation, ensuring consistent concatenation of stdout for issue reporting. This change enhances clarity and reduces complexity in the reporting logic.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
|
|
||
|
|
||
| ${report_data}= Catenate SEPARATOR=\n | ||
| ... Stdout: ${rsp.stdout} |
There was a problem hiding this comment.
Report data missing stderr and history fields
Medium Severity
The report_data variable only includes Stdout: ${rsp.stdout} but the PR description states it should include "stdout, stderr, history" for issue context. Both ${rsp.stderr} and ${history} variables are available and used later in the code for reporting, but they are not included in report_data that gets passed to the DynamicIssues methods. This reduces the debugging context available in generated issues, particularly missing error output which is often the most valuable information for troubleshooting failures.
Additional Locations (1)
stewartshea
deleted the
update/script-generic-add-report-to-issue-details
branch
1 participant
Enhance dynamic issue reporting in runbooks by adding support for report data. Updated methods in runbook.robot and DynamicIssues.py to include optional report data (stdout, stderr, history) when creating issues. This improves the clarity and context of generated issues, facilitating better debugging and tracking.
Note
Improves context for dynamically created issues and streamlines metric handling.
RW.DynamicIssuesto accept optionalreport_dataand append it todetailsfor bothprocess_file_based_issuesandprocess_json_query_issues(including extracted JSON path)git-script-cmd-env/runbook.robotandgit-script-cmd-json/runbook.robotto buildreport_data(fromrsp.stdout) and pass it toRW.DynamicIssues.Process File Based IssuesandProcess Json Query Issuesgit-script-cmd-*/sli.robot): remove automatic issue creation on non-numeric output/failed return codes; default non-numeric output to0and compute metric viaMETRIC_MODE.testscripts and README under both bundles to validateMETRIC_MODEbehaviorsWritten by Cursor Bugbot for commit 468b279. This will update automatically on new commits. Configure here.