Skip to content

Conversation

@reddevilmidzy
Copy link
Member

close: #692

Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to check the exact comment message everywhere, I usually only do it in one "main" test and then at places where it feels important to see what the exact comment was. In the rest of places I usually just use expect_comments((), N). But the current version is fine, and the change looks simple enough. Thanks!

Feel free to undraft when you feel it's ready.

@reddevilmidzy
Copy link
Member Author

We don't need to check the exact comment message everywhere, I usually only do it in one "main" test and then at places where it feels important to see what the exact comment was. In the rest of places I usually just use expect_comments((), N). But the current verison is fine, and the change looks simple enough. Thanks!

Feel free to undraft when you feel it's ready.

Aha okay, I'll keep that in mind next time
thank you!

@reddevilmidzy reddevilmidzy marked this pull request as ready for review February 11, 2026 09:16
Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Kobzol Kobzol added this pull request to the merge queue Feb 11, 2026
Merged via the queue into rust-lang:main with commit 189d3f8 Feb 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Send a comment when squashing begins

2 participants