Skip to content

Clarify std default hasher #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Amanieu merged 1 commit into from
Feb 5, 2026
Merged

Clarify std default hasher #682

Amanieu merged 1 commit into from
Feb 5, 2026
+4 −3

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Feb 2, 2026

Address #153

@clarfonthey
Copy link
Contributor

clarfonthey commented Feb 3, 2026 •
edited
Loading

I personally would rather link the docs for std::hash::DefaultHasher than say it's SipHash, so that it stays accurate even if libstd changes. The point is that it's different, and what exactly it is is independent from hashbrown's default.

@xtqqczze xtqqczze marked this pull request as draft February 3, 2026 19:32
@clarfonthey
Copy link
Contributor

clarfonthey commented Feb 3, 2026

(The change looks good! I can't merge but I can say at least that this looks ready to merge IMHO, so, it probably will be once someone else gets to it.)

@xtqqczze xtqqczze marked this pull request as ready for review February 3, 2026 19:57
@Amanieu Amanieu added this pull request to the merge queue Feb 5, 2026
Merged via the queue into rust-lang:master with commit d84a552 Feb 5, 2026
25 checks passed
@github-actions github-actions bot mentioned this pull request Feb 5, 2026
Open
@xtqqczze xtqqczze deleted the patch-1 branch February 5, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xtqqczze @clarfonthey @Amanieu