Skip to content

Conversation

@raushan728
Copy link

@raushan728 raushan728 commented Feb 11, 2026

This PR fixes the FIXME in hir-ty where dependent generic defaults (like struct T<A, B = A>) result in {unknown} when using a placeholder _.

The fix re-applies defaults after insert_type_vars in path.rs to ensure nested inference variables are correctly unified.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 11, 2026
@ShoyuVanilla
Copy link
Member

ShoyuVanilla commented Feb 11, 2026

That test is just sensitive to query graph changes, not flaky. You could just update the expectation to the actual output

@raushan728
Copy link
Author

thanks for the correction @ShoyuVanilla . I've updated the test expectations. I realized my previous local run was mistaken—the test is indeed sensitive to the query changes from this fix.

@ChayimFriedman2
Copy link
Contributor

I'm really not pleased with the solution here, and given that we need to get rid of the distinction between TyLoweringContext and InferenceContext anyway (as I said on Zulip), I would much prefer to solve this by that. That is larger work, of course.

@raushan728
Copy link
Author

Thanks @ChayimFriedman2. I just saw your messages on Zulip, let's discuss it further there."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants