Don't include current rustc version string in feature removed help#142943
Merged
bors merged 1 commit intorust-lang:masterfrom Jun 25, 2025
Merged
Don't include current rustc version string in feature removed help#142943bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
|
rustbot
added
the
T-compiler
jieyouxu
changed the title
jieyouxu
force-pushed
the
no-rustc-version
branch
from
4a24662 to
979fd4e
Compare
The version string is difficult to properly normalize out, and removing it isn't a huge deal (the user can query version info easily through `rustc --version` or `cargo --version`). The normalization options were all non-ideal: - Per-test version string normalization is nasty to maintain, and we need to maintain `n` copies of it. - Centralized compiletest normalization (with a directive opt-out) is also not ideal, because `cfg(version(..))` tests can't have those accidentally normalized out (and you'd have to remember to opt-out).
jieyouxu
force-pushed
the
no-rustc-version
branch
from
979fd4e to
db11e74
Compare
rustbot
added
the
S-waiting-on-review
Contributor
Collaborator
bors
added
S-waiting-on-bors
Contributor
|
Does this need beta nomination? |
bors
added a commit
that referenced
this pull request
Jun 24, 2025
Rollup of 9 pull requests Successful merges: - #142645 (Also emit suggestions for usages in the `non_upper_case_globals` lint) - #142657 (mbe: Clean up code with non-optional `NonterminalKind`) - #142799 (rustc_session: Add a structure for keeping both explicit and default sysroots) - #142805 (Emit a single error when importing a path with `_`) - #142882 (Lazy init diagnostics-only local_names in borrowck) - #142883 (Add impl_trait_in_bindings tests from #61773) - #142943 (Don't include current rustc version string in feature removed help) - #142965 ([RTE-497] Ignore `c-link-to-rust-va-list-fn` test on SGX platform) - #142972 (Add a missing mailmap entry) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jun 25, 2025
Rollup merge of #142943 - jieyouxu:no-rustc-version, r=compiler-errors Don't include current rustc version string in feature removed help The version string is difficult to properly normalize out, and removing it isn't a huge deal (the user can query version info easily through `rustc --version` or `cargo --version`). The normalization options were all non-ideal (see #142940 (comment)): - Per-test version string normalization is nasty to maintain, and we need to maintain `n` copies of it. See #142930 where the regex wasn't robust against different release channels. - Centralized compiletest normalization (with a directive opt-out) is also not ideal, because `cfg(version(..))` tests can't have those accidentally normalized out (and you'd have to remember to opt-out). r? `@workingjubilee` (discussed in #142940)
Member
Author
TL;DR: no. Sorry, I should've included more context:
I'll edit the PR description to include this further elaboration. |
Contributor
Yep, that's the part I was too lazy to look up.
Yeah, I corrected myself about that here: #141619 (comment) |
cuviper
added a commit
to cuviper/rust
that referenced
this pull request
Sep 11, 2025
These "you are using $RUSTC_VERSION" help messages were removed in rust-lang#142943, but rust-lang#142681 started before that and merged later, so its normalization is vestigial.
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Sep 12, 2025
test: remove an outdated normalization for rustc versions These "you are using $RUSTC_VERSION" help messages were removed in rust-lang#142943, but rust-lang#142681 started before that and merged later, so its normalization is vestigial.
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Sep 12, 2025
test: remove an outdated normalization for rustc versions These "you are using $RUSTC_VERSION" help messages were removed in rust-lang#142943, but rust-lang#142681 started before that and merged later, so its normalization is vestigial.
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Sep 12, 2025
test: remove an outdated normalization for rustc versions These "you are using $RUSTC_VERSION" help messages were removed in rust-lang#142943, but rust-lang#142681 started before that and merged later, so its normalization is vestigial.
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Sep 13, 2025
test: remove an outdated normalization for rustc versions These "you are using $RUSTC_VERSION" help messages were removed in rust-lang/rust#142943, but rust-lang/rust#142681 started before that and merged later, so its normalization is vestigial.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the current rust version substring in the help message introduced in #141642, not the whole help or the removal version (i.e. the "spirit" of #141619 is still preserved). Only the "current rust version" substring normalization is the hard-to-normalize bit.
The current version string is difficult to properly normalize out, and removing it isn't a huge deal (the user can query version info easily through
rustc --versionorcargo --version).The normalization options were all non-ideal (see #142940 (comment)):
ncopies of it. See Account for beta revisions when normalizing versions #142930 where the regex wasn't robust against different release channels.cfg(version(..))tests can't have those accidentally normalized out (and you'd have to remember to opt-out).More context
.betasubstring on the beta channel. That PR is already beta-backported, so this PR does not need to be.