rustc_target: introduce Arch by tamird · Pull Request #147645 · rust-lang/rust

tamird · 2025-10-13T18:56:43Z

Improve type safety by using an enum rather than strings.

rustbot · 2025-10-13T18:56:47Z

These commits modify compiler targets.
(See the Target Tier Policy.)

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in cfg and check-cfg configuration

cc @Urgau

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

rustbot · 2025-10-13T18:56:50Z

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

compiler/rustc_target/src/spec/mod.rs

nnethercote · 2025-10-13T22:03:22Z

This seems like a good change, but I think it's large enough that it should have an MCP, meeting the criteria of "Significant internal refactorings/changes" -- it's a simple change, but one that touches a lot of files.

tamird · 2025-10-14T01:34:22Z

This seems like a good change, but I think it's large enough that it should have an MCP, meeting the criteria of "Significant internal refactorings/changes" -- it's a simple change, but one that touches a lot of files.

Done: rust-lang/compiler-team#926.

Urgau · 2025-10-14T16:39:23Z

I'm curious if this has any performance impact, let's see.

@bors try @rust-timer queue

rustc_target: introduce Architecture

rust-bors · 2025-10-14T18:51:39Z

☀️ Try build successful (CI)
Build commit: 3a048fa (3a048fab4921cf40ac8c01ca813c3fde6e3a2caa, parent: e100792918c8bd9e0cb830f96fc9b171e8892fa1)

rust-timer · 2025-10-14T21:32:40Z

Finished benchmarking commit (3a048fa): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.8%	[0.8%, 0.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -2.1%, secondary 1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.8%	[1.0%, 3.6%]	7
Improvements ✅ (primary)	-2.1%	[-2.7%, -1.6%]	2
Improvements ✅ (secondary)	-1.3%	[-1.4%, -1.3%]	2
All ❌✅ (primary)	-2.1%	[-2.7%, -1.6%]	2

Cycles

Results (primary 2.1%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	3.6%	[3.6%, 3.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.4%	[-3.4%, -3.4%]	1
All ❌✅ (primary)	2.1%	[2.1%, 2.1%]	1

Binary size

Results (secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	1
All ❌✅ (primary)	-	-	0

Bootstrap: 473.51s -> 474.979s (0.31%)
Artifact size: 388.11 MiB -> 388.13 MiB (0.01%)

bors · 2025-10-15T01:35:17Z

☔ The latest upstream changes (presumably #147692) made this pull request unmergeable. Please resolve the merge conflicts.

nnethercote · 2025-10-24T09:04:33Z

Looks like two things are needed:

Rename Architecture as Arch (there were 8 people agreeing with this suggestion in the Zulip thread, judging by the emoji responses)
Add the Unknown variant.

@rustbot author

bors · 2025-11-05T04:15:13Z

⌛ Testing commit 26b0560 with merge c0ff72f...

bors · 2025-11-05T07:24:32Z

☀️ Test successful - checks-actions
Approved by: nnethercote
Pushing c0ff72f to master...

github-actions · 2025-11-05T07:27:41Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 6e41e61 (parent) -> c0ff72f (this PR)

Test differences

Show 4 test diffs

Stage 0

tests::custom_arch_propagates_from_json: [missing] -> pass (J1)

Stage 1

tests::custom_arch_propagates_from_json: [missing] -> pass (J0)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard c0ff72ffc4e88a2bbb69add95a4946d213996895 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

pr-check-1: 1588.1s -> 1964.4s (+23.7%)
i686-gnu-1: 7223.9s -> 8442.1s (+16.9%)
aarch64-gnu-llvm-20-2: 2211.7s -> 2551.1s (+15.3%)
x86_64-gnu-llvm-20: 2485.2s -> 2792.9s (+12.4%)
dist-aarch64-apple: 6938.1s -> 6090.1s (-12.2%)
x86_64-gnu-gcc: 3256.4s -> 3622.2s (+11.2%)
i686-gnu-2: 5596.1s -> 6196.2s (+10.7%)
x86_64-gnu-llvm-20-2: 5352.8s -> 5916.4s (+10.5%)
x86_64-gnu-tools: 3328.3s -> 3667.2s (+10.2%)
dist-powerpc-linux: 4739.4s -> 5187.4s (+9.5%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-11-05T09:18:21Z

Finished benchmarking commit (c0ff72f): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.0%]	2
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 1.0%, secondary -1.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.8%	[2.8%, 2.8%]	1
Regressions ❌ (secondary)	3.0%	[0.8%, 6.1%]	6
Improvements ✅ (primary)	-0.9%	[-0.9%, -0.9%]	1
Improvements ✅ (secondary)	-3.9%	[-5.6%, -1.8%]	12
All ❌✅ (primary)	1.0%	[-0.9%, 2.8%]	2

Cycles

Results (primary -3.8%, secondary -0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.4%	[1.6%, 5.1%]	6
Improvements ✅ (primary)	-3.8%	[-3.8%, -3.8%]	1
Improvements ✅ (secondary)	-5.2%	[-9.1%, -1.5%]	6
All ❌✅ (primary)	-3.8%	[-3.8%, -3.8%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 475.404s -> 474.063s (-0.28%)
Artifact size: 390.71 MiB -> 390.97 MiB (0.06%)

Relevant upstream PR: - rust-lang/rust#147645 (rustc_target: introduce Arch) Resolves: model-checking#4450

Relevant upstream PR: - rust-lang/rust#147645 (rustc_target: introduce Arch) Resolves: #4450 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

rustc_target: Remove unused Arch::PowerPC64LE This variant has been added in rust-lang#147645, but actually unused since target_arch for powerpc64le- targets is "powerpc64". (The difference between powerpc64- and powerpc64le- targets is identified by target_endian.) Note: This is an internal cleanup and does NOT remove `powerpc64le-*` targets.

Rollup merge of #150966 - arch-powerpc64le, r=petrochenkov rustc_target: Remove unused Arch::PowerPC64LE This variant has been added in #147645, but actually unused since target_arch for powerpc64le- targets is "powerpc64". (The difference between powerpc64- and powerpc64le- targets is identified by target_endian.) Note: This is an internal cleanup and does NOT remove `powerpc64le-*` targets.

rustc_target: Remove unused Arch::PowerPC64LE This variant has been added in rust-lang/rust#147645, but actually unused since target_arch for powerpc64le- targets is "powerpc64". (The difference between powerpc64- and powerpc64le- targets is identified by target_endian.) Note: This is an internal cleanup and does NOT remove `powerpc64le-*` targets.

rustbot assigned nnethercote Oct 13, 2025

Urgau reviewed Oct 13, 2025

View reviewed changes

compiler/rustc_target/src/spec/mod.rs Outdated Show resolved Hide resolved

tamird force-pushed the arch-enum branch 2 times, most recently from 289dc7b to 23b2e59 Compare October 13, 2025 20:42

This comment has been minimized.

Sign in to view

tamird force-pushed the arch-enum branch from 2d03fd5 to 2158f47 Compare October 13, 2025 21:58

tamird mentioned this pull request Oct 14, 2025

Replace rustc_target::specTarget::arch string with enum rust-lang/compiler-team#926

Closed

3 tasks

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Oct 14, 2025

Auto merge of #147645 - tamird:arch-enum, r=<try>

3a048fa

rustc_target: introduce Architecture

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 14, 2025

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 14, 2025

tamird force-pushed the arch-enum branch from 2158f47 to a175998 Compare October 23, 2025 17:44

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 24, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 5, 2025

bors merged commit c0ff72f into rust-lang:master Nov 5, 2025
12 checks passed

rustbot added this to the 1.93.0 milestone Nov 5, 2025

tamird deleted the arch-enum branch November 5, 2025 15:02

tautschnig added a commit to tautschnig/kani that referenced this pull request Nov 6, 2025

Upgrade Rust toolchain to 2025-11-06

05da9c2

Relevant upstream PR: - rust-lang/rust#147645 (rustc_target: introduce Arch) Resolves: model-checking#4450

tautschnig mentioned this pull request Nov 6, 2025

Upgrade Rust toolchain to 2025-11-06 model-checking/kani#4451

Merged

nnethercote mentioned this pull request Nov 6, 2025

Tracking issue for MCP 926: Replace rustc_target::specTarget::arch string with enum #148352

Closed

5 tasks

taiki-e mentioned this pull request Jan 11, 2026

rustc_target: Remove unused Arch::PowerPC64LE #150966

Merged

Uh oh!

Conversation

tamird commented Oct 13, 2025

Uh oh!

rustbot commented Oct 13, 2025

Uh oh!

rustbot commented Oct 13, 2025

Uh oh!

Uh oh!

This comment has been minimized.

nnethercote commented Oct 13, 2025

Uh oh!

tamird commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Urgau commented Oct 14, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Oct 14, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Oct 14, 2025

Overall result: ❌✅ regressions and improvements - no action needed

Uh oh!

bors commented Oct 15, 2025

Uh oh!

This comment has been minimized.

nnethercote commented Oct 24, 2025

Uh oh!

bors commented Nov 5, 2025

Uh oh!

bors commented Nov 5, 2025

Uh oh!

Uh oh!

github-actions bot commented Nov 5, 2025

Test differences

Stage 0

Stage 1

Job duration changes

Uh oh!

rust-timer commented Nov 5, 2025

Overall result: ❌✅ regressions and improvements - no action needed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

tamird commented Oct 14, 2025 •

edited

Loading