-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
Add aarch64-asan-windows-msvc tier 3 target #149893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
eholk
wants to merge
6
commits into
rust-lang:main
Choose a base branch
from
eholk:windows-asan-aarch64
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+117
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
|
☔ The latest upstream changes (presumably #149831) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion to #149644 and #149892 that adds a target that can be used to enable AddressSanitizer by default on Windows for ARM64 devices.
It currently includes #149892, but that should land first and then I will rebase this one on top of it.
I and the other maintainers of the Windows MSVC targets will be responsible for this target.
(cc @ChrisDenton @dpaoliello @Fulgen301 @lambdageek @sivadeilra @wesleywiser)
This target follows the naming conventions agreed on for the similar
x86_64-asan-linux-gnutarget.This PR introduces no new legal terms or conditions.
Understood.
This is able to implement the same portions of the standard library that are supported by the other MSVC targets.
This PR includes such documentation.
Understood.
Understood.
This target uses LLVM for code generation.