Add FCW for derive helper attributes that will conflict with built-in attributes

[nik-rev]

Adds a future-compatibility-warning deny-by-default lint that helps catch invalid derive helper attribute names early.

This issues the lint, saying that ignore helper will clash with the built-in ignore attribute.

#![crate_type = "proc-macro"]
#![deny(ambiguous_derive_helpers)] 
use proc_macro::TokenStream; 

#[proc_macro_derive(Trait, attributes(ignore))]
pub fn example(input: TokenStream) -> TokenStream {
    TokenStream::new()
}

If you actually tried to use that ignore helper attribute, you won't be able to due to the ambiguity:

#[derive(Trait)]
struct Foo {
    #[ignore]
    field: (),
}

Produces:

error[E0659]: `ignore` is ambiguous
 --> src/lib.rs:5:7
  |
5 |     #[ignore]
  |       ^^^^^^ ambiguous name
  |
  = note: ambiguous because of a name conflict with a builtin attribute
  = note: `ignore` could refer to a built-in attribute
note: `ignore` could also refer to the derive helper attribute defined here
 --> src/lib.rs:3:10
  |
3 | #[derive(Trait)]
  |          ^^^^^

[rustbot]

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

[rustbot]

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[chenyukang]

@bors r=chenyukang

[rust-bors]

📌 Commit 4dda363 has been approved by chenyukang

It is now in the queue for this repository.

[petrochenkov]

New deprecation lints go through language team process, and the lint name also doesn't follow naming conventions.

[chenyukang]

@bors r-

[rust-bors]

Commit 4dda363 has been unapproved.

[nik-rev]

@rustbot label +I-lang-nominated

I am nominating this for lang-team attention.

What name should this lint have? The current name doesn't follow the naming conventions

My main idea is allow(derive_helper_attr_with_same_name_as_a_builtin_attr), but that's quite long

[chenyukang]

Thanks!
@bors r=chenyukang

[rust-bors]

📌 Commit f4eca01 has been approved by chenyukang

It is now in the queue for this repository.

[JonathanBrouwer]

@bors r-
#152421 (comment)

[rust-bors]

Commit f4eca01 has been unapproved.

This PR was contained in a rollup (#152421), which was also unapproved.

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[nik-rev]

@bors r+

[rust-bors]

@nik-rev: 🔑 Insufficient privileges: not in review users

[nik-rev]

@bors r=JonathanBrouwer

[rust-bors]

@nik-rev: 🔑 Insufficient privileges: not in review users

[nik-rev]

@rustbot ready

[JonathanBrouwer]

@bors try jobs=test-various

[rust-bors]

☀️ Try build successful (CI)
Build commit: 8b451e4 (8b451e434ccbe03d091c882a267b1ee8474752b3, parent: d00ba922591daa3d0a8b0f3cdf54c610097c24ea)

[JonathanBrouwer]

@bors r=chenyukang

[rust-bors]

📌 Commit 846e4ee has been approved by chenyukang

It is now in the queue for this repository.