Port `#[patchable_function_entry]` to attr parser by Bryntet · Pull Request #151340 · rust-lang/rust

Bryntet · 2026-01-18T21:24:25Z

This is the last codegen attr (see #151335 and #151336)!

Tracking issue: #131229

currently this PR is rebased on #151336 to make CI pass for the last commit

to see the actual changes in this PR you can look here

rustbot · 2026-01-18T21:26:03Z

Error: Parsing assign command in comment failed: ...' @' | error: specify user to assign to at >| ''...

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

Bryntet · 2026-01-19T10:10:04Z

r? @JonathanBrouwer

would like review in the current state, it's not ready to merge though until #151336 is through, and then I'll add another commit making a let Some(attribute::Parsed(attr)) = attr else {continue;} in compiler/rustc_codegen_ssa/src/codegen_attrs.rs since this is the last unparsed codegenned attr done :)

rustbot · 2026-01-19T10:10:15Z

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

Bryntet · 2026-01-19T10:12:51Z

actually I'll rebase this on #151336 so the whole PR can be reviewed in it's entirety right now, so ignore those first two commits until it's merged into main

rustbot · 2026-01-19T17:14:24Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

compiler/rustc_attr_parsing/src/session_diagnostics.rs

JonathanBrouwer · 2026-01-19T17:23:41Z

I rebased the PR to make reviewing easier.

@bors delegate
r=me after fixing my comment

rust-bors · 2026-01-19T17:23:44Z

✌️ @Bryntet, you can now approve this pull request!

If @JonathanBrouwer told you to "r=me" after making some further change, then please make that change and post @bors r=JonathanBrouwer.

JonathanBrouwer · 2026-01-19T17:25:11Z

@rustbot author

rustbot · 2026-01-19T17:25:15Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

Bryntet · 2026-01-19T21:19:15Z

@bors r=JonathanBrouwer

rust-bors · 2026-01-19T21:19:17Z

📌 Commit 79dba29 has been approved by JonathanBrouwer

It is now in the queue for this repository.

JonathanBrouwer · 2026-01-19T22:00:43Z

@bors r-
r=me with green ci

rust-bors · 2026-01-19T22:00:47Z

Commit 79dba29 has been unapproved.

JonathanBrouwer · 2026-01-20T19:26:01Z

@bors r+ rollup

rust-bors · 2026-01-20T19:26:04Z

📌 Commit a0b3ee2 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@ghost

Rollup of 6 pull requests Successful merges: - #150436 (`c_variadic`: impl `va_copy` and `va_end` as Rust intrinsics) - #151340 (Port `#[patchable_function_entry]` to attr parser) - #151351 (Deduplicate diagnostics for const trait supertraits) - #151424 (missing colon after the compile-flags directive) - #151428 (Port variance attrs to attr parser.) - #151429 (s390x: Support aligned stack datalayout) Failed merges: - #151343 (Port some crate level attrs to the attribute parser) r? @ghost

Rollup merge of #151340 - port_patchable_function_entry, r=JonathanBrouwer Port `#[patchable_function_entry]` to attr parser This is the last codegen attr (see #151335 and #151336)! Tracking issue: #131229 currently this PR is rebased on #151336 to make CI pass for the last commit to see the actual changes in this PR you can look [here](https://github.com/rust-lang/rust/pull/151340/changes/3e731f7e84301a898a36e46ee5e4845ff9bda98a..55111fb468808b733e97170a841217a67666ac33)

@ghost

Rollup of 6 pull requests Successful merges: - rust-lang/rust#150436 (`c_variadic`: impl `va_copy` and `va_end` as Rust intrinsics) - rust-lang/rust#151340 (Port `#[patchable_function_entry]` to attr parser) - rust-lang/rust#151351 (Deduplicate diagnostics for const trait supertraits) - rust-lang/rust#151424 (missing colon after the compile-flags directive) - rust-lang/rust#151428 (Port variance attrs to attr parser.) - rust-lang/rust#151429 (s390x: Support aligned stack datalayout) Failed merges: - rust-lang/rust#151343 (Port some crate level attrs to the attribute parser) r? @ghost

@ghost

Rollup of 6 pull requests Successful merges: - rust-lang/rust#150436 (`c_variadic`: impl `va_copy` and `va_end` as Rust intrinsics) - rust-lang/rust#151340 (Port `#[patchable_function_entry]` to attr parser) - rust-lang/rust#151351 (Deduplicate diagnostics for const trait supertraits) - rust-lang/rust#151424 (missing colon after the compile-flags directive) - rust-lang/rust#151428 (Port variance attrs to attr parser.) - rust-lang/rust#151429 (s390x: Support aligned stack datalayout) Failed merges: - rust-lang/rust#151343 (Port some crate level attrs to the attribute parser) r? @ghost

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 18, 2026

This comment has been minimized.

Sign in to view

Bryntet force-pushed the port_patchable_function_entry branch from f36627d to 52bf01f Compare January 19, 2026 09:42

rustbot assigned JonathanBrouwer Jan 19, 2026

Bryntet marked this pull request as ready for review January 19, 2026 10:10

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 19, 2026

Bryntet force-pushed the port_patchable_function_entry branch from 52bf01f to 4c9dfab Compare January 19, 2026 10:11

Bryntet force-pushed the port_patchable_function_entry branch 2 times, most recently from 70485f5 to 55111fb Compare January 19, 2026 10:27

This comment has been minimized.

Sign in to view

Bryntet force-pushed the port_patchable_function_entry branch from 55111fb to fe7430c Compare January 19, 2026 11:27

JonathanBrouwer added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Jan 19, 2026

JonathanBrouwer force-pushed the port_patchable_function_entry branch from fe7430c to 0917c59 Compare January 19, 2026 17:14

JonathanBrouwer removed the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Jan 19, 2026

JonathanBrouwer mentioned this pull request Jan 19, 2026

Tracking issue: Attribute refactor #131229

Open

9 tasks

JonathanBrouwer reviewed Jan 19, 2026

View reviewed changes

compiler/rustc_attr_parsing/src/session_diagnostics.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 19, 2026

Bryntet force-pushed the port_patchable_function_entry branch from 0917c59 to 79dba29 Compare January 19, 2026 21:18

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 19, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 19, 2026

Bryntet added 2 commits January 20, 2026 11:46

Port #[patchable_function_entry] to attr parser

b65e1fd

only process parsed attrs for codegen check

a0b3ee2

Bryntet force-pushed the port_patchable_function_entry branch from 79dba29 to a0b3ee2 Compare January 20, 2026 10:46

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 20, 2026

jhpratt mentioned this pull request Jan 21, 2026

Rollup of 6 pull requests #151436

Merged

rust-bors bot merged commit 79be7a0 into rust-lang:main Jan 21, 2026
11 checks passed

rustbot added this to the 1.95.0 milestone Jan 21, 2026

Uh oh!

Conversation

Bryntet commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jan 18, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

Bryntet commented Jan 19, 2026

Uh oh!

rustbot commented Jan 19, 2026

Uh oh!

Bryntet commented Jan 19, 2026

Uh oh!

This comment has been minimized.

rustbot commented Jan 19, 2026

Uh oh!

Uh oh!

JonathanBrouwer commented Jan 19, 2026

Uh oh!

rust-bors bot commented Jan 19, 2026

Uh oh!

JonathanBrouwer commented Jan 19, 2026

Uh oh!

rustbot commented Jan 19, 2026

Uh oh!

Bryntet commented Jan 19, 2026

Uh oh!

rust-bors bot commented Jan 19, 2026

Uh oh!

This comment has been minimized.

JonathanBrouwer commented Jan 19, 2026

Uh oh!

rust-bors bot commented Jan 19, 2026

Uh oh!

JonathanBrouwer commented Jan 20, 2026

Uh oh!

rust-bors bot commented Jan 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Bryntet commented Jan 18, 2026 •

edited

Loading