Remove a couple of unnecessary flags and env vars in bootstrap #151745
+5
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
|
r? @clubby789 rustbot has assigned @clubby789. Use |
clubby789
reviewed
Jan 27, 2026
| @@ -1277,8 +1277,6 @@ impl Builder<'_> { | |||
| // | |||
| // FIXME: should update code to not require this env var | |||
Contributor
There was a problem hiding this comment.
Should this FIXME be moved/removed, or does 'this env var' refer to all of these? 🤔
Member
Author
There was a problem hiding this comment.
I believe it also refers to CFG_COMPILER_BUILD_TRIPLE and maybe CFG_RELEASE_CHANNEL.
Member
Author
There was a problem hiding this comment.
I just went through the history. This fixme originates from the initial commit of the rust version of the build system and back then only applied to CFG_COMPILER_HOST_TRIPLE. The other env vars didn't exist yet. As such I removed the todo.
Contributor
|
LGTM, but it could be good to update the fixme to 'these env vars' if that's appropriate; r=me when green with or without |
This lint is allowed by default nowadays.
Rustc no longer depends on winapi. Only cg_clif, cg_gcc and rustfmt still use it, none of which are libraries to compile against. And in case of both cg_clif and cg_gcc it never ends up in an artifact we ship. For cg_clif it only shows up when the jit mode is enabled, which is not the case for the version we ship. For cg_gcc it is used by a test executable, which isn't shipped either.
These flags should be available on the bootstrap compiler.
bjorn3
force-pushed
the
remove_unnecessary_flags
branch
from
e0b76a3 to
257ea3b
Compare
Member
Author
|
Removed the |
Member
Author
|
@bors r=clubby789 |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 7, 2026
…=clubby789 Remove a couple of unnecessary flags and env vars in bootstrap
Contributor
|
⌛ Testing commit 257ea3b with merge 3807573... Workflow: https://github.com/rust-lang/rust/actions/runs/21784866555 |
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 7, 2026
Remove a couple of unnecessary flags and env vars in bootstrap
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 7, 2026
…=clubby789 Remove a couple of unnecessary flags and env vars in bootstrap
Contributor
|
@bors yield |
Contributor
|
Auto build cancelled. Cancelled workflows: The next pull request likely to be tested is #152307. |
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 7, 2026
…uwer Rollup of 7 pull requests Successful merges: - #151745 (Remove a couple of unnecessary flags and env vars in bootstrap) - #152217 (Convert to inline diagnostics in `rustc_lint`) - #152056 (RwLock: refine documentation to emphasize non-reentrancy guarantees) - #152261 (Introduce helper `ty::Generics::has_own_self`) - #152288 (Allow only a single accepter per attribute) - #152292 (Minor change for readability) - #152300 (Port `rustc_regions` to the new attribute parser)
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 7, 2026
…uwer Rollup of 7 pull requests Successful merges: - #151745 (Remove a couple of unnecessary flags and env vars in bootstrap) - #152217 (Convert to inline diagnostics in `rustc_lint`) - #152056 (RwLock: refine documentation to emphasize non-reentrancy guarantees) - #152261 (Introduce helper `ty::Generics::has_own_self`) - #152288 (Allow only a single accepter per attribute) - #152292 (Minor change for readability) - #152300 (Port `rustc_regions` to the new attribute parser)
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 7, 2026
…uwer Rollup of 7 pull requests Successful merges: - #151745 (Remove a couple of unnecessary flags and env vars in bootstrap) - #152217 (Convert to inline diagnostics in `rustc_lint`) - #152056 (RwLock: refine documentation to emphasize non-reentrancy guarantees) - #152261 (Introduce helper `ty::Generics::has_own_self`) - #152288 (Allow only a single accepter per attribute) - #152292 (Minor change for readability) - #152300 (Port `rustc_regions` to the new attribute parser)
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 7, 2026
…uwer Rollup of 7 pull requests Successful merges: - #151745 (Remove a couple of unnecessary flags and env vars in bootstrap) - #152217 (Convert to inline diagnostics in `rustc_lint`) - #152056 (RwLock: refine documentation to emphasize non-reentrancy guarantees) - #152261 (Introduce helper `ty::Generics::has_own_self`) - #152288 (Allow only a single accepter per attribute) - #152292 (Minor change for readability) - #152300 (Port `rustc_regions` to the new attribute parser)
rust-timer
added a commit
that referenced
this pull request
Feb 8, 2026
Rollup merge of #151745 - bjorn3:remove_unnecessary_flags, r=clubby789 Remove a couple of unnecessary flags and env vars in bootstrap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.