Add inline syntax for diagnostic messages #151872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-translation
3 tasks
JonathanBrouwer
force-pushed
the
diag3
branch
from
11f286d to
88a8652
Compare
JonathanBrouwer
force-pushed
the
diag3
branch
from
88a8652 to
ca2be71
Compare
Collaborator
|
cc @davidtwco, @TaKO8Ki
cc @davidtwco, @TaKO8Ki
cc @davidtwco, @TaKO8Ki |
rustbot
added
S-waiting-on-review
Bryntet
reviewed
Feb 1, 2026
Member
|
is this affect perf somehow? implementation wise it looks fine |
Contributor
Author
|
@Kivooeo Most of the changed code runs in a proc macro, so this can't affect performance. The changes in |
Member
|
good to know, then i guess i could sign this off, thanks for working on it! im no expecting this to break anything, so rollup @bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 2, 2026
…uwer Rollup of 12 pull requests Successful merges: - #149596 (resolve: Report more visibility-related early resolution ambiguities for imports) - #151695 (compiletest: Support `--extern` modifiers with `proc-macro` directive) - #151938 (Use `#![feature(adt_const_params)]` for static query flags) - #151172 (Use default field values in a few more cases) - #151825 (more float constants) - #151870 (regression test for alias-relate changes in lub) - #151872 (Add inline syntax for diagnostic messages) - #151902 (explain why we dont skip some of this work when there are field projections) - #151909 (Skip overlapping spans in argument error suggestions) - #151978 (Query cleanups) - #151979 (Fix uninitialized UEFI globals in tests) - #151992 (Port `#[rustc_hidden_type_of_opaque]` to attribute parser)
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 2, 2026
…uwer Rollup of 12 pull requests Successful merges: - #149596 (resolve: Report more visibility-related early resolution ambiguities for imports) - #151695 (compiletest: Support `--extern` modifiers with `proc-macro` directive) - #151938 (Use `#![feature(adt_const_params)]` for static query flags) - #151172 (Use default field values in a few more cases) - #151825 (more float constants) - #151870 (regression test for alias-relate changes in lub) - #151872 (Add inline syntax for diagnostic messages) - #151902 (explain why we dont skip some of this work when there are field projections) - #151909 (Skip overlapping spans in argument error suggestions) - #151978 (Query cleanups) - #151979 (Fix uninitialized UEFI globals in tests) - #151992 (Port `#[rustc_hidden_type_of_opaque]` to attribute parser)
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 3, 2026
…uwer Rollup of 12 pull requests Successful merges: - #149596 (resolve: Report more visibility-related early resolution ambiguities for imports) - #151695 (compiletest: Support `--extern` modifiers with `proc-macro` directive) - #151938 (Use `#![feature(adt_const_params)]` for static query flags) - #151172 (Use default field values in a few more cases) - #151825 (more float constants) - #151870 (regression test for alias-relate changes in lub) - #151872 (Add inline syntax for diagnostic messages) - #151902 (explain why we dont skip some of this work when there are field projections) - #151909 (Skip overlapping spans in argument error suggestions) - #151978 (Query cleanups) - #151979 (Fix uninitialized UEFI globals in tests) - #151992 (Port `#[rustc_hidden_type_of_opaque]` to attribute parser)
rust-timer
added a commit
that referenced
this pull request
Feb 3, 2026
Rollup merge of #151872 - JonathanBrouwer:diag3, r=Kivooeo Add inline syntax for diagnostic messages This PR adds the new inline diagnostics syntax needed for #151366. The syntax itself is briefly described in the MCP: rust-lang/compiler-team#959 To test these changes: * I added quite a few uitests * I converted the first crate `rustc_attr_parsing` to the new syntax in a separate PR: #151944 r? @Kivooeo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new inline diagnostics syntax needed for #151366.
The syntax itself is briefly described in the MCP: rust-lang/compiler-team#959
To test these changes:
rustc_attr_parsingto the new syntax in a separate PR: Convert to inline diagnostics inrustc_attr_parsing#151944r? @Kivooeo