Skip to content

Conversation

@cuviper
Copy link
Member

@cuviper cuviper commented Feb 5, 2026

r? cuviper

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 5, 2026
@rust-log-analyzer

This comment has been minimized.

@cuviper
Copy link
Member Author

cuviper commented Feb 5, 2026

@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Feb 6, 2026

You'll need to include #152194 and #152116

JonathanBrouwer and others added 2 commits February 6, 2026 08:34
@rustbot rustbot added the T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. label Feb 6, 2026
The derived `T: Copy` constraint is not appropriate for an iterator by
reference, but we generally do not want `Copy` on iterators anyway.

(cherry picked from commit 2bae85e)
This implementation doesn't need the derived `T: Clone`.

(cherry picked from commit 9052155)
(cherry picked from commit 08cd2ac)
(cherry picked from commit 8f7d556)
@cuviper
Copy link
Member Author

cuviper commented Feb 10, 2026

@bors r+ rollup=never p=1

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 10, 2026

📌 Commit e1dd1bb has been approved by cuviper

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 10, 2026
@tgross35
Copy link
Contributor

tgross35 commented Feb 10, 2026

Wasn't only the Copy change from #151613 accepted for backport?

(Only based on Zulip, I don't see anything at https://hackmd.io/03D-yhzfSp6Sf8mH9cbu0Q#Backports-rusttf151613-Align-ArrayWindows-trait-impls-with-Windows)

@cuviper
Copy link
Member Author

cuviper commented Feb 10, 2026

I believe @Amanieu decided in the meeting that we should go ahead with it all. I can definitely cut it back though if that's not the case.

@cuviper
Copy link
Member Author

cuviper commented Feb 10, 2026

Allowing time to make sure of that...

@bors r-

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 10, 2026
@tgross35
Copy link
Contributor

I don't think it matters all that much 🤷‍♂️ but figured it was worth checking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants