Add regression test for nested const arg ICE under mGCA #152406
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using deeply nested const generic function calls in the type position of a const parameter with both `generic_const_exprs` and `min_generic_const_args` used to ICE with "unhandled node ConstArg" in `generics_of`. The compiler now produces proper errors instead.
This comment was marked as resolved.
This comment was marked as resolved.
Urgau
added
T-compiler
Contributor
Member
|
i think this should have been closed as part of #150025. i dont think we need more test coverage here yeah. thanks for the PR though, filing tests for these issues is valuable work :) |
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #143358.
Add a regression test for #143358, fixed by #149136.